From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [RFC Part2 PATCH v3 10/26] KVM: Introduce
 KVM_MEMORY_ENCRYPT_REGISTER/UNREGISTER_RAM ioctl
Date: Tue, 12 Sep 2017 15:50:55 -0500
Message-ID: <e4bae100-38d9-b46a-bc6f-cdfbc6018188@amd.com>
References: <20170724200303.12197-1-brijesh.singh@amd.com>
 <20170724200303.12197-11-brijesh.singh@amd.com>
 <20170912202940.qmq5oq2cx2cmhwqg@pd.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org,
        x86@kernel.org, kvm@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Joerg Roedel <joro@8bytes.org>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= <rkrcmar@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
To: Borislav Petkov <bp@suse.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20170912202940.qmq5oq2cx2cmhwqg@pd.tnic>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 09/12/2017 03:29 PM, Borislav Petkov wrote:

...

>> +	int (*memory_encryption_unregister_ram)(struct kvm *kvm,
>> +					struct kvm_memory_encrypt_ram *ram);
>>   };
> 
> You can shorten those prefixes to "mem_enc" or so and struct
> kvm_memory_encrypt_ram to struct enc_region - which is exactly what it
> is - an encrypted memory region descriptor - and then fit each function
> on a single line.
> 

Sure, I can do that. In one of the feedback Paolo recommended
KVM_MEMORY_ENCRYPT_* ioctl name hence I tried to stick with the same name
for structure. I am flexible to use 'struct enc_region' but I personally
prefer to keep "mem" somewhere in the structure naming to indicate its for
*memory* encryption -- maybe struct kvm_mem_enc_region.


...
>> +						struct kvm_memory_encrypt_ram)
> 
> As with KVM_MEMORY_ENCRYPT_OP, those two need to be in the KVM API document.
> 

Yes, I missed updating the Documentation/virtual/kvm/api.txt for these new
ioctls. I will update it.