From: Paolo Bonzini <pbonzini@redhat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
James Hogan <james.hogan@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paul Burton" <paul.burton@imgtec.com>,
linux-mips@linux-mips.org, kvm@vger.kernel.org
Subject: Re: [PATCH 8/9] MIPS: KVM: Decode RDHWR more strictly
Date: Tue, 5 Jul 2016 14:39:57 +0200 [thread overview]
Message-ID: <e4bd15b0-ec72-14d4-7bc4-e71e6b2accc3@redhat.com> (raw)
In-Reply-To: <24b4b1b6-2a58-63f8-f2c2-78ecc6eceb4e@cogentembedded.com>
On 05/07/2016 13:16, Sergei Shtylyov wrote:
>> if (inst.r_format.opcode == spec3_op &&
>> - inst.r_format.func == rdhwr_op) {
>> + inst.r_format.func == rdhwr_op &&
>> + inst.r_format.rs == 0 &&
>> + (inst.r_format.re >> 3) == 0) {
>
> Inner parens not necessary here.
They are nicer though.
Paolo
next prev parent reply other threads:[~2016-07-05 12:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 18:35 [PATCH 0/9] MIPS: KVM: MIPS r6 support James Hogan
2016-07-04 18:35 ` [PATCH 3/9] MIPS: KVM: Fix fpu.S misassembly with r6 James Hogan
2016-07-04 18:35 ` [PATCH 4/9] MIPS: KVM: Fix pre-r6 ll/sc instructions on r6 James Hogan
2016-07-04 18:35 ` [PATCH 5/9] MIPS: KVM: Don't save/restore lo/hi for r6 James Hogan
2016-07-04 18:35 ` [PATCH 6/9] MIPS: KVM: Support r6 compact branch emulation James Hogan
2016-07-04 18:35 ` [PATCH 7/9] MIPS: KVM: Recognise r6 CACHE encoding James Hogan
2016-07-04 18:35 ` [PATCH 8/9] MIPS: KVM: Decode RDHWR more strictly James Hogan
2016-07-05 11:16 ` Sergei Shtylyov
2016-07-05 12:39 ` Paolo Bonzini [this message]
2016-07-05 14:34 ` Sergei Shtylyov
2016-07-05 12:51 ` Ralf Baechle
2016-07-04 18:35 ` [PATCH 9/9] MIPS: KVM: Emulate generic QEMU machine on r6 T&E James Hogan
2016-07-05 13:58 ` [PATCH 0/9] MIPS: KVM: MIPS r6 support Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bd15b0-ec72-14d4-7bc4-e71e6b2accc3@redhat.com \
--to=pbonzini@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=rkrcmar@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox