From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v4 2/3] nvdimm acpi: introduce _FIT Date: Thu, 3 Nov 2016 18:08:04 +0800 Message-ID: References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com> <20161103095353.GA5154@stefanha-x1.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Stefan Hajnoczi Return-path: Received: from mga03.intel.com ([134.134.136.65]:53963 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbcKCKPY (ORCPT ); Thu, 3 Nov 2016 06:15:24 -0400 In-Reply-To: <20161103095353.GA5154@stefanha-x1.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: > On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: >> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr) >> cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out)); >> } >> >> +#define NVDIMM_DSM_RET_STATUS_SUCCESS 0 /* Success */ >> +#define NVDIMM_DSM_RET_STATUS_UNSUPPORT 1 /* Not Supported */ >> +#define NVDIMM_DSM_RET_STATUS_INVALID 3 /* Invalid Input Parameters */ > > Not worth changing but please make each logical change a separate patch > in the future. This patch is cluttered with NVDIMM_DSM_RET_STATUS_ > constant renaming. It's easier to review, bisect, and backport when > structured as separate patches. > Yes, indeed. Thanks for your suggestion, will pay more attention. :P