Re: [PATCH v2 4/4] hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h

Easwar Hariharan
2024-11-14T21:35:56Z

On 11/7/2024 2:32 PM, Nuno Das Neves wrote:
> Switch to using hvhdk.h everywhere in the kernel. This header includes
> all the new Hyper-V headers in include/hyperv, which form a superset of
> the definitions found in hyperv-tlfs.h.
>
> This makes it easier to add new Hyper-V interfaces without being
> restricted to those in the TLFS doc (reflected in hyperv-tlfs.h).
>
> To be more consistent with the original Hyper-V code, the names of some
> definitions are changed slightly. Update those where needed.
>
> hyperv-tlfs.h is no longer included anywhere - hvhdk.h can serve
> the same role, but with an easier path for adding new definitions.

Michael already mentioned this, I'd also agree that it's better to
remove hyperv-tlfs.h entirely since it's been superseded.

This looks good to me, I'll wait for v3 addressing the other comments to
take a look again.

- Easwar

<...>