RE: [PATCH v2 1/4] hyperv: Move hv_connection_id to hyperv-tlfs.h

Michael Kelley
2024-11-11T04:13:15Z

From: Nuno Das Neves <nunodasneves@linux.microsoft.com> Sent: Thursday, November 7, 2024 2:32 PM
>
> This definition is in the wrong file; it is part of the TLFS doc.
>
> Acked-by: Wei Liu <wei.liu@kernel.org>
> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> ---
> include/asm-generic/hyperv-tlfs.h | 9 +++++++++
> include/linux/hyperv.h | 9 ---------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/asm-generic/hyperv-tlfs.h b/include/asm-generic/hyperv-tlfs.h
> index 814207e7c37f..52274c9aefef 100644
> --- a/include/asm-generic/hyperv-tlfs.h
> +++ b/include/asm-generic/hyperv-tlfs.h
> @@ -871,4 +871,13 @@ struct hv_mmio_write_input {
> u8 data[HV_HYPERCALL_MMIO_MAX_DATA_LENGTH];
> } __packed;
>
> +/* Define connection identifier type. */
> +union hv_connection_id {
> + u32 asu32;
> + struct {
> + u32 id:24;
> + u32 reserved:8;
> + } u;
> +};
> +
> #endif
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 22c22fb91042..d0893ec488ae 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -768,15 +768,6 @@ struct vmbus_close_msg {
> struct vmbus_channel_close_channel msg;
> };
>
> -/* Define connection identifier type. */
> -union hv_connection_id {
> - u32 asu32;
> - struct {
> - u32 id:24;
> - u32 reserved:8;
> - } u;
> -};
> -
> enum vmbus_device_type {
> HV_IDE = 0,
> HV_SCSI,
> --
> 2.34.1

Reviewed-by: Michael Kelley <mhklinux@outlook.com>