RE: [PATCH v2 2/4] hyperv: Clean up unnecessary #includes

Michael Kelley
2024-11-11T04:13:24Z

From: Nuno Das Neves <nunodasneves@linux.microsoft.com> Sent: Thursday, November 7, 2024 2:32 PM
>
> Remove includes of linux/hyperv.h, mshyperv.h, and hyperv-tlfs.h where
> they are not used.
>
> Acked-by: Wei Liu <wei.liu@kernel.org>
> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> ---
> arch/arm64/hyperv/hv_core.c | 1 -
> arch/x86/hyperv/hv_apic.c | 1 -
> arch/x86/hyperv/hv_init.c | 1 -
> arch/x86/hyperv/hv_proc.c | 1 -
> arch/x86/hyperv/ivm.c | 1 -
> arch/x86/hyperv/mmu.c | 1 -
> arch/x86/include/asm/kvm_host.h | 1 -
> arch/x86/include/asm/mshyperv.h | 1 -
> arch/x86/mm/pat/set_memory.c | 2 --
> 9 files changed, 10 deletions(-)
>
> diff --git a/arch/arm64/hyperv/hv_core.c b/arch/arm64/hyperv/hv_core.c
> index f1ebc025e1df..7a746a5a6b42 100644
> --- a/arch/arm64/hyperv/hv_core.c
> +++ b/arch/arm64/hyperv/hv_core.c
> @@ -11,7 +11,6 @@
> #include <linux/types.h>
> #include <linux/export.h>
> #include <linux/mm.h>
> -#include <linux/hyperv.h>
> #include <linux/arm-smccc.h>
> #include <linux/module.h>
> #include <asm-generic/bug.h>
> diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> index 0569f579338b..f022d5f64fb6 100644
> --- a/arch/x86/hyperv/hv_apic.c
> +++ b/arch/x86/hyperv/hv_apic.c
> @@ -23,7 +23,6 @@
> #include <linux/vmalloc.h>
> #include <linux/mm.h>
> #include <linux/clockchips.h>
> -#include <linux/hyperv.h>
> #include <linux/slab.h>
> #include <linux/cpuhotplug.h>
> #include <asm/hypervisor.h>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 17a71e92a343..1a6354b3e582 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -27,7 +27,6 @@
> #include <linux/version.h>
> #include <linux/vmalloc.h>
> #include <linux/mm.h>
> -#include <linux/hyperv.h>
> #include <linux/slab.h>
> #include <linux/kernel.h>
> #include <linux/cpuhotplug.h>
> diff --git a/arch/x86/hyperv/hv_proc.c b/arch/x86/hyperv/hv_proc.c
> index 3fa1f2ee7b0d..b74c06c04ff1 100644
> --- a/arch/x86/hyperv/hv_proc.c
> +++ b/arch/x86/hyperv/hv_proc.c
> @@ -3,7 +3,6 @@
> #include <linux/vmalloc.h>
> #include <linux/mm.h>
> #include <linux/clockchips.h>
> -#include <linux/hyperv.h>
> #include <linux/slab.h>
> #include <linux/cpuhotplug.h>
> #include <linux/minmax.h>
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> index 60fc3ed72830..b56d70612734 100644
> --- a/arch/x86/hyperv/ivm.c
> +++ b/arch/x86/hyperv/ivm.c
> @@ -7,7 +7,6 @@
> */
>
> #include <linux/bitfield.h>
> -#include <linux/hyperv.h>
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <asm/svm.h>
> diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c
> index 1cc113200ff5..cc8c3bd0e7c2 100644
> --- a/arch/x86/hyperv/mmu.c
> +++ b/arch/x86/hyperv/mmu.c
> @@ -1,6 +1,5 @@
> #define pr_fmt(fmt) "Hyper-V: " fmt
>
> -#include <linux/hyperv.h>
> #include <linux/log2.h>
> #include <linux/slab.h>
> #include <linux/types.h>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 4a68cb3eba78..3627eab994a3 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -24,7 +24,6 @@
> #include <linux/pvclock_gtod.h>
> #include <linux/clocksource.h>
> #include <linux/irqbypass.h>
> -#include <linux/hyperv.h>
> #include <linux/kfifo.h>
>
> #include <asm/apic.h>
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 390c4d13956d..47ca48062547 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -9,7 +9,6 @@
> #include <asm/hyperv-tlfs.h>
> #include <asm/nospec-branch.h>
> #include <asm/paravirt.h>
> -#include <asm/mshyperv.h>
>
> /*
> * Hyper-V always provides a single IO-APIC at this MMIO address.
> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> index 44f7b2ea6a07..85fa0d4509f0 100644
> --- a/arch/x86/mm/pat/set_memory.c
> +++ b/arch/x86/mm/pat/set_memory.c
> @@ -32,8 +32,6 @@
> #include <asm/pgalloc.h>
> #include <asm/proto.h>
> #include <asm/memtype.h>
> -#include <asm/hyperv-tlfs.h>
> -#include <asm/mshyperv.h>
>
> #include "../mm_internal.h"
>
> --
> 2.34.1

Looks good!

Reviewed-by: Michael Kelley <mhklinux@outlook.com>