From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574FA22A4E4 for ; Fri, 13 Jun 2025 18:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749837689; cv=none; b=iVQ0WpYoxmJuPxxAK1EtN0Y4WGO6mUeLZQEvVmmdKds9rlNt1Ey9H+bOF47q8PoZd/2i0BEpqWSDR2sNKa8G0Uu58vi6tUjTNZTM+SckvLLcwdNCgxPWLH9v4KJBh4FnxqE7cSELJIzm7yYuYLMRq+lSOmpiGhv1X9s8s4frkv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749837689; c=relaxed/simple; bh=Esw6ov3l8A5CaAtmTWBwTU2PX3RZ3hr0DfdZzU8Tu9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V4MKgdSvC32ixSiUVKGwgyAxqneSTxuqVfMD/kA0BOEk0/Ynk8FDxswkSEKlsfEK6teAm6/hAmLx6LFQf7KGW7XDuEhaZMt4tGT230UfFLzmpbh0Ra5NXZRolVHE8kYhOj4hSdft96IDIyA0mlRFTES8kwRh9jOlTbU1G/fyg+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y/4ksMYK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y/4ksMYK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749837686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Bsu+Wcnjd7wtWlxV8RLC0OdC2mEBW/GepWDmRtxUl30=; b=Y/4ksMYKP9Z9gZ6pPTdBzMoi+JaqM15DkLTjTTnMct4dxZMi+wO0p9oErW7KXK0ALwKLbs 7r2O6nCa0Xwcl2p/pbPQIx3B8C/cInA+Mmm0YpOGb/inAcBvyqi3CqFJWeBA7OMWG1Uw2j 1qYIVWvn773V1KA1h4wLIkgzIa6ytfs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-portNK3EP8-ksdHZkSSdjw-1; Fri, 13 Jun 2025 14:01:22 -0400 X-MC-Unique: portNK3EP8-ksdHZkSSdjw-1 X-Mimecast-MFC-AGG-ID: portNK3EP8-ksdHZkSSdjw_1749837682 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4e713e05bso1323583f8f.3 for ; Fri, 13 Jun 2025 11:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749837681; x=1750442481; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Bsu+Wcnjd7wtWlxV8RLC0OdC2mEBW/GepWDmRtxUl30=; b=KNrLDZ46KR7I7ZOMAjRdu0YirikC1hVsHNMLVwRMuj/J73YTvcZxPOI3+jQ046+Ie0 87X1cCKom0Tvqxsy7CSqEleCaZJI4CtkNjwfdLr+Dhp+BptUXA0eyxLOlLoBXFZ5dWde 2/2fXD1EpYQNGAZqYvgBdwsW6KhNR97xtTF3NDVYuvxgb4KPg5hwF0B8LZ/ktj2I7FbS DoQDyfW38SugeQ4nCCh0qtLSy7nASy1WAR77UPfXfsmhXaKUZQ7Qd4qEbbDhWrnJIQuu flGn2DC48M6PC3iK/cboKI/jkr5y4DBkxldZ5sXsDHNxswX8l7N/bOqB9n68C5BPyZQH TTnw== X-Forwarded-Encrypted: i=1; AJvYcCVvbu7be9DRyIkX03eHWXRxBmpHllUJ9AOBfNh5+wvF7lvrCSNBIAFIUXwFs/c/A1PgH6c=@vger.kernel.org X-Gm-Message-State: AOJu0YwXGtBsyCAKa2ujWm74nDIvazrU74JpPHIxaxNOmT5vQHGhp4Zb fal753VlK5fMP/rVw2Vs/HHjZNKG1ebNW2G+BfWhLsxA7Pja2FSUwyA4J2+3ulUKltp/rDpBqzw 0nFA03S2LpZ6L8UOjXdWy8pqSHjoDhbJ5MSthvw74Lda1aZ+ZbQJYJw== X-Gm-Gg: ASbGncvlSr3v1Pyqd3aCVd4oExLBZvclQbtS5aB7rz/l18XCa8dRzXFqRz/edawnybf i7tlNyEvvf5pemX9wSOx3DrZMS5D1mCqDHg+KHdenieWc/WE5AHqf82TvEJ3yVvFXRyYLjBVhpa OaEWPnujnesX8KY9cY3nH2zEVfmP8723CWyfzzx9exCv7m/Ld47lgmVSxZIos6K1+mJ53CSmI2q R7PiJc/Bea0U/LUHVaTY5Iw3YaC12ZSG77cA6D/8fI3IIGME25agLP853AzyTLWSneehBDo+wD8 8XwJuPQHHDoALMukzSUK9b1nQu7WZ4sMcCbNJ0d5Kyll373vwXeEoyauO0GGLkLpfQ8vKaKQke4 BEeYioTZfaAC7XjauMFNyF8ocr7rTcNOQcuoQnm0VZxvTS8Nuow== X-Received: by 2002:a05:6000:2310:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3a5723679c2mr776525f8f.3.1749837681560; Fri, 13 Jun 2025 11:01:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWRgs9/eOjv6Ni0Z0GgYf1+t6oOJ0Vg7B/D9l25oYMJ7KcIy5VjWpy1ryHHls/6YKXmWWXpA== X-Received: by 2002:a05:6000:2310:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3a5723679c2mr776461f8f.3.1749837681034; Fri, 13 Jun 2025 11:01:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b089c2sm3004716f8f.59.2025.06.13.11.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 11:01:20 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 20:01:19 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm/hugetlb: Remove prepare_hugepage_range() To: Peter Xu , Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Jason Gunthorpe , Alex Mastro , Nico Pache , Huacai Chen , Thomas Bogendoerfer , Muchun Song , Oscar Salvador , loongarch@lists.linux.dev, linux-mips@vger.kernel.org References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-3-peterx@redhat.com> <050B65EF-6A1E-44A8-87D5-152FA9A60641@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > > But if we want to be super accurate, it's indeed different, in that the old > hugetlb code was checking stack top with STACK_TOP, which is > mips_stack_top() for MIPS: it's a value that might be slightly less than > TASK_SIZE.. > > So strictly speaking, there's indeed a trivial difference on the oddity of > defining stack top, but my guess is nothing will be affected. I can add > some explanation into the commit message in that case. Yeah, that would be good. Acked-by: David Hildenbrand -- Cheers, David / dhildenb