Re: [kvm-unit-tests PATCH v1] s390x: Add tests for execute-type instructions

[Nina Schoetterl-Glausch <nsg@linux.ibm.com>]

On Thu, 2023-02-23 at 08:52 +0100, Nico Boehr wrote:
> Quoting Nina Schoetterl-Glausch (2023-02-22 12:47:42)
> > Test the instruction address used by targets of an execute instruction.
> > When the target instruction calculates a relative address, the result is
> > relative to the target instruction, not the execute instruction.
> > 
> > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> [...]
> > diff --git a/s390x/Makefile b/s390x/Makefile
> > index 97a61611..6cf8018b 100644
> > --- a/s390x/Makefile
> > +++ b/s390x/Makefile
> > @@ -39,6 +39,7 @@ tests += $(TEST_DIR)/panic-loop-extint.elf
> >  tests += $(TEST_DIR)/panic-loop-pgm.elf
> >  tests += $(TEST_DIR)/migration-sck.elf
> >  tests += $(TEST_DIR)/exittime.elf
> > +tests += $(TEST_DIR)/ex.elf
> 
> You didn't add your new test to unittests.cfg, is this intentional?

Nope, I just forgot.

@Thomas, I guess I should also add it to s390x-kvm in .gitlab-ci.yml,
since the test passes on KVM?

> 
> Otherwise:
> 
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>

Thanks!