From: Paolo Bonzini <pbonzini@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: rkrcmar@redhat.com, kvm@vger.kernel.org,
sean.j.christopherson@intel.com, jmattson@google.com,
vkuznets@redhat.com, Mihai Carabas <mihai.carabas@oracle.com>
Subject: Re: [PATCH 2/2] KVM: x86: Prevent set vCPU into INIT/SIPI_RECEIVED state when INIT are latched
Date: Mon, 11 Nov 2019 15:02:29 +0100 [thread overview]
Message-ID: <ea6e861f-a293-e0da-6364-547fe23cbab1@redhat.com> (raw)
In-Reply-To: <BB5CCF97-38DE-4037-83E3-22E921D25651@oracle.com>
On 11/11/19 14:46, Liran Alon wrote:
>> + * INITs are latched while CPU is in specific states
>> + * (SMM, VMX non-root mode, SVM with GIF=0).
> I didn’t want this line of comment as it may diverge from the implementation of kvm_vcpu_latch_init().
> That’s why I removed it.
>
>> * Because a CPU cannot be in these states immediately
>> * after it has processed an INIT signal (and thus in
>> * KVM_MP_STATE_INIT_RECEIVED state), just eat SIPIs
Got it... on the other hand knowing the specific states clarifies why
they cannot be in that state immediately after processing INIT. It's a
bit of a catch-22 indeed.
Paolo
next prev parent reply other threads:[~2019-11-11 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 9:16 [PATCH 0/2] KVM: x86: Fix userspace API regarding latched init Liran Alon
2019-11-11 9:16 ` [PATCH 1/2] KVM: x86: Evaluate latched_init in KVM_SET_VCPU_EVENTS when vCPU not in SMM Liran Alon
2019-11-11 9:16 ` [PATCH 2/2] KVM: x86: Prevent set vCPU into INIT/SIPI_RECEIVED state when INIT are latched Liran Alon
2019-11-11 13:40 ` Paolo Bonzini
2019-11-11 13:46 ` Liran Alon
2019-11-11 14:02 ` Paolo Bonzini [this message]
2019-11-11 13:40 ` [PATCH 0/2] KVM: x86: Fix userspace API regarding latched init Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6e861f-a293-e0da-6364-547fe23cbab1@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mihai.carabas@oracle.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox