RE: [PATCH v8 06/10] iommufd/selftest: Add coverage for IOMMU_HWPT_INVALIDATE ioctl

Tian, Kevin
2023-12-28T06:14:44Z

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 28, 2023 12:14 AM
>
> + /* Negative test: trigger error */
> + num_inv = 1;
> + inv_reqs[0].flags =
> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR;
> + inv_reqs[0].iotlb_id = 0;
> + test_cmd_hwpt_invalidate(nested_hwpt_id[0], inv_reqs,
> +
> IOMMU_HWPT_INVALIDATE_DATA_SELFTEST,
> + sizeof(*inv_reqs), &num_inv);
> + assert(num_inv == 1);
> + assert(inv_reqs[0].hw_error ==
> IOMMU_TEST_INVALIDATE_FAKE_ERROR);
> +

instead of removing TRIGGER_ERROR|ALL err check, it makes more
sense to keep it but making it a similar case as above.