From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver
Date: Mon, 10 Oct 2016 16:00:56 -0500
Message-ID: <ec42d924-8ba0-4225-0084-d090ab8ffdc3@redhat.com>
References: <1476131317-358-1-git-send-email-kwankhede@nvidia.com>
 <1476131317-358-2-git-send-email-kwankhede@nvidia.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="KXvpXwQpxoHVul6xTvn8oC6kkSS2fNrBM"
Cc: jike.song@intel.com, kvm@vger.kernel.org, kevin.tian@intel.com,
        qemu-devel@nongnu.org, bjsdjshi@linux.vnet.ibm.com
To: Kirti Wankhede <kwankhede@nvidia.com>, alex.williamson@redhat.com,
        pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54092 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752436AbcJJVA7 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 10 Oct 2016 17:00:59 -0400
In-Reply-To: <1476131317-358-2-git-send-email-kwankhede@nvidia.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--KXvpXwQpxoHVul6xTvn8oC6kkSS2fNrBM
Content-Type: multipart/mixed; boundary="PpieIvtFMrCUm3Oq7VTLvETHmHsBa3Q5h";
 protected-headers="v1"
From: Eric Blake <eblake@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>, alex.williamson@redhat.com,
 pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com
Cc: jike.song@intel.com, kvm@vger.kernel.org, kevin.tian@intel.com,
 qemu-devel@nongnu.org, bjsdjshi@linux.vnet.ibm.com
Message-ID: <ec42d924-8ba0-4225-0084-d090ab8ffdc3@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver
References: <1476131317-358-1-git-send-email-kwankhede@nvidia.com>
 <1476131317-358-2-git-send-email-kwankhede@nvidia.com>
In-Reply-To: <1476131317-358-2-git-send-email-kwankhede@nvidia.com>

--PpieIvtFMrCUm3Oq7VTLvETHmHsBa3Q5h
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 10/10/2016 03:28 PM, Kirti Wankhede wrote:
> Design for Mediated Device Driver:
> Main purpose of this driver is to provide a common interface for mediat=
ed
> device management that can be used by different drivers of different
> devices.
>=20

>=20
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> Signed-off-by: Neo Jia <cjia@nvidia.com>
> Change-Id: I73a5084574270b14541c529461ea2f03c292d510
> ---

> +++ b/drivers/vfio/mdev/Kconfig
> @@ -0,0 +1,12 @@
> +
> +config VFIO_MDEV
> +    tristate "Mediated device driver framework"
> +    depends on VFIO
> +    default n
> +    help
> +        Provides a framework to virtualize device.

Feels like a missing word or two here, maybe 'virtualize a _____ device' =
?

> +	See Documentation/vfio-mdev/vfio-mediated-device.txt for more details=
=2E
> +
> +        If you don't know what do here, say N.
> +

> +++ b/drivers/vfio/mdev/mdev_core.c
> @@ -0,0 +1,363 @@
> +/*
> + * Mediated device Core Driver
> + *
> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
> + *     Author: Neo Jia <cjia@nvidia.com>
> + *	       Kirti Wankhede <kwankhede@nvidia.com>
> + *
> + * This program is free software; you can redistribute it and/or modif=
y
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Umm - "All rights reserved" is incompatible with GPLv2.  Either you
reserved the rights (and it is therefore not GPL), or it is GPL (and you
are specifically granting rights, and therefore not all rights are
reserved).

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--PpieIvtFMrCUm3Oq7VTLvETHmHsBa3Q5h--

--KXvpXwQpxoHVul6xTvn8oC6kkSS2fNrBM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJX/AGIAAoJEKeha0olJ0Nq1FYIAISrajMuOxpDCZux64pGYCJ9
+DkekHkuNBGaj/X3LFCclGOqCnvi7zAAjhtin91kGxWh+DYFQ4yd/jkfIHjJ+OwU
vp+4WFOfmhGpmBY712vlHtoEG882F8+Jj2v7WD/H5VavPNKR7679l21dWCHSxnzR
XSb2b+bGTzt4hF6wCXQegG7D97DS0wRquTy4voWo8W2WscGAK50qUS8fkLGT0rOP
vvorxjPDgdrFO+/krzT/EFORnxuZeILgMa9PM38rtE8ycfD3/4Vdf16divCEjy2q
23zdr3mzcFJ0iBChjblnxYDy94HzydKH41pYOl1u9xrp++pGW/OAC7j4GlOv1XI=
=hj+q
-----END PGP SIGNATURE-----

--KXvpXwQpxoHVul6xTvn8oC6kkSS2fNrBM--