From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Jintack Lim <jintack@cs.columbia.edu>
Cc: KVM General <kvm@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
will.deacon@arm.com, linux@armlinux.org.uk,
andre.przywara@arm.com, Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly
Date: Tue, 29 Nov 2016 16:53:25 +0000 [thread overview]
Message-ID: <ee2dacff-691c-7548-ff71-3a992f399333@arm.com> (raw)
In-Reply-To: <0a475329-6f50-42ae-3244-f0767c56ce09@arm.com>
On 29/11/16 09:36, Marc Zyngier wrote:
> On 29/11/16 03:28, Jintack Lim wrote:
>> On Mon, Nov 28, 2016 at 1:39 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>> On 28/11/16 17:43, Marc Zyngier wrote:
>> This looks much cleaner than my patch.
>> While we are at it, is it worth to consider that we just need to set
>> those bits once for VHE case, not for every world switch as an
>> optimization?
>
> Ah! That's a much better idea indeed! And we could stop messing with
> cntvoff_el2 as well, as it doesn't need to be restored to zero on exit.
> Could you try and respin something along those lines?
>
fyi, we have a static_key based cpus_have_const_cap() for Constant cap
checking (like this case) available in linux-next. May be you could make use
of that instead of alternatives.
Cheers
Suzuki
next prev parent reply other threads:[~2016-11-29 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 16:46 [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly Jintack Lim
2016-11-28 17:43 ` Marc Zyngier
2016-11-28 18:39 ` Marc Zyngier
2016-11-28 19:42 ` Christoffer Dall
2016-11-29 9:37 ` Marc Zyngier
2016-11-29 10:47 ` Christoffer Dall
2016-11-29 10:53 ` Marc Zyngier
2016-11-29 3:28 ` Jintack Lim
2016-11-29 9:36 ` Marc Zyngier
2016-11-29 11:29 ` Jintack Lim
2016-11-29 16:53 ` Suzuki K Poulose [this message]
2016-11-29 21:05 ` Jintack Lim
2016-11-30 13:31 ` Marc Zyngier
2016-11-30 13:41 ` Jintack Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2dacff-691c-7548-ff71-3a992f399333@arm.com \
--to=suzuki.poulose@arm.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jintack@cs.columbia.edu \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox