From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, seanjc@google.com,
pbonzini@redhat.com, jmattson@google.com
Cc: hpa@zytor.com, rmk+kernel@armlinux.org.uk, peterz@infradead.org,
james.morse@arm.com, lukas.bulwahn@gmail.com,
arjan@linux.intel.com, j.granados@samsung.com,
sibs@chinatelecom.cn, nik.borisov@suse.com, michael.roth@amd.com,
nikunj.dadhania@amd.com, babu.moger@amd.com, x86@kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com, ananth.narayan@amd.com,
sandipan.das@amd.com, manali.shukla@amd.com,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 1/4] x86/split_lock: Move Split and Bus lock code to a dedicated file
Date: Wed, 7 Aug 2024 11:12:03 +0530 [thread overview]
Message-ID: <ee91fb42-7a06-4082-80af-9bd1401e06be@amd.com> (raw)
In-Reply-To: <878cae8c-4da1-ca80-7215-24cdcb80474a@amd.com>
>> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
>> index 5857a0f5d514..9f74e0011f01 100644
>> --- a/arch/x86/kernel/cpu/Makefile
>> +++ b/arch/x86/kernel/cpu/Makefile
>> @@ -27,6 +27,7 @@ obj-y += aperfmperf.o
>> obj-y += cpuid-deps.o
>> obj-y += umwait.o
>> obj-y += capflags.o powerflags.o
>> +obj-y += bus_lock.o
>
> Since the whole file is protected by a "#if defined", why not just use
> that here and conditionally build it?
>
> You could also create a Kconfig that is set when CPU_SUP_INTEL is
> selected and, later when CPU_SUP_AMD is selected, and use that
> (CONFIG_X86_BUS_LOCK or such).
New CONFIG seems like a better option. Will respin with that.
Thanks for the review,
Ravi
next prev parent reply other threads:[~2024-08-07 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 12:54 [PATCH v3 0/4] x86/cpu: Add Bus Lock Detect support for AMD Ravi Bangoria
2024-08-06 12:54 ` [PATCH v3 1/4] x86/split_lock: Move Split and Bus lock code to a dedicated file Ravi Bangoria
2024-08-06 13:49 ` Tom Lendacky
2024-08-07 5:42 ` Ravi Bangoria [this message]
2024-08-06 12:54 ` [PATCH v3 2/4] x86/bus_lock: Add support for AMD Ravi Bangoria
2024-08-06 14:08 ` Tom Lendacky
2024-08-06 12:54 ` [PATCH v3 3/4] KVM: SVM: Don't advertise Bus Lock Detect to guest if SVM support is missing Ravi Bangoria
2024-08-06 14:12 ` Tom Lendacky
2024-08-06 12:54 ` [PATCH v3 4/4] KVM: SVM: Add Bus Lock Detect support Ravi Bangoria
2024-08-06 14:39 ` Tom Lendacky
2024-08-07 5:41 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee91fb42-7a06-4082-80af-9bd1401e06be@amd.com \
--to=ravi.bangoria@amd.com \
--cc=ananth.narayan@amd.com \
--cc=arjan@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=j.granados@samsung.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=manali.shukla@amd.com \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=nikunj.dadhania@amd.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=sibs@chinatelecom.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox