From: Paolo Bonzini <pbonzini@redhat.com>
To: Ricardo Koller <ricarkol@google.com>, kvm@vger.kernel.org
Cc: kvmarm@lists.cs.columbia.edu, seanjc@google.com, maz@kernel.org,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH] KVM: selftests: Address extra memslot parameters in vm_vaddr_alloc
Date: Thu, 8 Jul 2021 19:16:16 +0200 [thread overview]
Message-ID: <eebf14e1-cd5c-a55d-cd68-620df1c9bcf0@redhat.com> (raw)
In-Reply-To: <20210702201042.4036162-1-ricarkol@google.com>
On 02/07/21 22:10, Ricardo Koller wrote:
> Commit a75a895e6457 ("KVM: selftests: Unconditionally use memslot 0 for
> vaddr allocations") removed the memslot parameters from vm_vaddr_alloc.
> It addressed all callers except one under lib/aarch64/, due to a race
> with commit e3db7579ef35 ("KVM: selftests: Add exception handling
> support for aarch64")
>
> Fix the vm_vaddr_alloc call in lib/aarch64/processor.c.
>
> Reported-by: Zenghui Yu <yuzenghui@huawei.com>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
> ---
> tools/testing/selftests/kvm/lib/aarch64/processor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/aarch64/processor.c b/tools/testing/selftests/kvm/lib/aarch64/processor.c
> index 9f49f6caafe5..632b74d6b3ca 100644
> --- a/tools/testing/selftests/kvm/lib/aarch64/processor.c
> +++ b/tools/testing/selftests/kvm/lib/aarch64/processor.c
> @@ -401,7 +401,7 @@ void route_exception(struct ex_regs *regs, int vector)
> void vm_init_descriptor_tables(struct kvm_vm *vm)
> {
> vm->handlers = vm_vaddr_alloc(vm, sizeof(struct handlers),
> - vm->page_size, 0, 0);
> + vm->page_size);
>
> *(vm_vaddr_t *)addr_gva2hva(vm, (vm_vaddr_t)(&exception_handlers)) = vm->handlers;
> }
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-07-08 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 20:10 [PATCH] KVM: selftests: Address extra memslot parameters in vm_vaddr_alloc Ricardo Koller
2021-07-05 9:57 ` Eric Auger
2021-07-08 17:16 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebf14e1-cd5c-a55d-cd68-620df1c9bcf0@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox