From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Oliver Upton <oupton@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Suppress warning in __kvm_gfn_to_hva_cache_init
Date: Thu, 20 Feb 2020 12:22:59 +0100 [thread overview]
Message-ID: <f08f7a3b-bd23-e8cd-2fd4-e0f546ad02e5@redhat.com> (raw)
In-Reply-To: <20200218190729.GD28156@linux.intel.com>
On 18/02/20 20:07, Sean Christopherson wrote:
> On Tue, Feb 18, 2020 at 10:47:56AM -0800, Oliver Upton wrote:
>> Particularly draconian compilers warn of a possible uninitialized use of
>> the nr_pages_avail variable. Silence this warning by initializing it to
>> zero.
> Can you check if the warning still exists with commit 6ad1e29fe0ab ("KVM:
> Clean up __kvm_gfn_to_hva_cache_init() and its callers")? I'm guessing
> (hoping?) the suppression is no longer necessary.
What if __gfn_to_hva_many and gfn_to_hva_many are marked __always_inline?
Thanks,
Paolo
next prev parent reply other threads:[~2020-02-20 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 18:47 [PATCH] KVM: Suppress warning in __kvm_gfn_to_hva_cache_init Oliver Upton
2020-02-18 19:07 ` Sean Christopherson
2020-02-18 21:34 ` Oliver Upton
2020-02-18 22:21 ` Sean Christopherson
2020-02-20 11:22 ` Paolo Bonzini [this message]
2020-02-21 4:32 ` Oliver Upton
2020-02-21 8:24 ` Paolo Bonzini
2020-02-21 8:34 ` Oliver Upton
2020-02-21 9:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f08f7a3b-bd23-e8cd-2fd4-e0f546ad02e5@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=oupton@google.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).