* [PATCH] KVM: x86: Fix error & warning in i8254.h [not found] <tencent_EA89B0582F8F8C3CC33C9F7AE407FC956F09@qq.com> @ 2023-07-12 6:02 ` shijie001 2023-07-18 6:48 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 2+ messages in thread From: shijie001 @ 2023-07-12 6:02 UTC (permalink / raw) To: tglx, mingo, bp, dave.hansen, x86 Cc: hpa, kvm, linux-kernel, seanjc, pbonzini The following checkpatch error & warning are removed: WARNING: please, no space before tabs ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Jie Shi <shijie001@208suo.com> --- arch/x86/kvm/i8254.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h index a768212ba821..89eab61cfc51 100644 --- a/arch/x86/kvm/i8254.h +++ b/arch/x86/kvm/i8254.h @@ -27,7 +27,7 @@ struct kvm_kpit_state { struct kvm_kpit_channel_state channels[3]; u32 flags; bool is_periodic; - s64 period; /* unit: ns */ + s64 period; /* unit: ns */ struct hrtimer timer; struct mutex lock; @@ -52,7 +52,7 @@ struct kvm_pit { #define KVM_SPEAKER_BASE_ADDRESS 0x61 #define KVM_PIT_MEM_LENGTH 4 #define KVM_PIT_FREQ 1193181 -#define KVM_MAX_PIT_INTR_INTERVAL HZ / 100 +#define KVM_MAX_PIT_INTR_INTERVAL (HZ / 100) #define KVM_PIT_CHANNEL_MASK 0x3 struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: Fix error & warning in i8254.h 2023-07-12 6:02 ` [PATCH] KVM: x86: Fix error & warning in i8254.h shijie001 @ 2023-07-18 6:48 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 2+ messages in thread From: Philippe Mathieu-Daudé @ 2023-07-18 6:48 UTC (permalink / raw) To: shijie001, tglx, mingo, bp, dave.hansen, x86 Cc: hpa, kvm, linux-kernel, seanjc, pbonzini On 12/7/23 08:02, shijie001@208suo.com wrote: > The following checkpatch error & warning are removed: > WARNING: please, no space before tabs > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Jie Shi <shijie001@208suo.com> > --- > arch/x86/kvm/i8254.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > struct mutex lock; > @@ -52,7 +52,7 @@ struct kvm_pit { > #define KVM_SPEAKER_BASE_ADDRESS 0x61 > #define KVM_PIT_MEM_LENGTH 4 > #define KVM_PIT_FREQ 1193181 > -#define KVM_MAX_PIT_INTR_INTERVAL HZ / 100 > +#define KVM_MAX_PIT_INTR_INTERVAL (HZ / 100) This looks like dead code, maybe better just remove? > #define KVM_PIT_CHANNEL_MASK 0x3 > > struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags); ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_EA89B0582F8F8C3CC33C9F7AE407FC956F09@qq.com>
2023-07-12 6:02 ` [PATCH] KVM: x86: Fix error & warning in i8254.h shijie001
2023-07-18 6:48 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox