Re: [kvm-unit-tests PATCH v1 3/3] s390x: smp: make stop stopped cpu look the same as the running case

[Eric Farman <farman@linux.ibm.com>]

On Tue, 2022-04-12 at 11:30 +0200, Nico Boehr wrote:
> Adjust the stop stopped CPU case such that it looks the same as the
> stop running
> CPU case: use the nowait variant, handle the error code in the same
> way and make
> the report messages look the same.
> 
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>

Reviewed-by: Eric Farman <farman@linux.ibm.com>

> ---
>  s390x/smp.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/s390x/smp.c b/s390x/smp.c
> index 5257852c35a7..de3aba71c956 100644
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -144,8 +144,9 @@ static void test_stop(void)
>  	report(smp_cpu_stopped(1), "cpu stopped");
>  
>  	report_prefix_push("stop stopped CPU");
> -	report(!smp_cpu_stop(1), "STOP succeeds");
> -	report(smp_cpu_stopped(1), "CPU is stopped");
> +	rc = smp_cpu_stop_nowait(1);
> +	report(!rc, "return code");
> +	report(smp_cpu_stopped(1), "cpu stopped");
>  	report_prefix_pop();
>  
>  	report_prefix_pop();