From: Robert Hoo <robert.hu@linux.intel.com>
To: Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: Yuan Yao <yuan.yao@linux.intel.com>,
pbonzini@redhat.com, seanjc@google.com,
kirill.shutemov@linux.intel.com, kvm@vger.kernel.org,
Jingqi Liu <jingqi.liu@intel.com>
Subject: Re: [PATCH v3 5/9] KVM: x86: MMU: Integrate LAM bits when build guest CR3
Date: Wed, 21 Dec 2022 16:55:27 +0800 [thread overview]
Message-ID: <f233bea01059908d3305e77818e2f3f3f158be55.camel@linux.intel.com> (raw)
In-Reply-To: <20221221075034.yx5unrmkkwubvpm2@linux.intel.com>
On Wed, 2022-12-21 at 15:50 +0800, Yu Zhang wrote:
> > No. CR4.LAM_SUP isn't an enablement switch over CR3.LAM_U{48,57},
> > they're parallel relationship, CR4.LAM_SUP controls supervisor mode
> > addresses has LAM or not while CR3.LAM_U controls user mode
> > address's
> > LAM enablement.
>
> Unfortunately, the spec(the one in your cover letter) has a bug in
> "10.1 ENUMERATION, ENABLING, AND CONFIGURATION":
>
> CR4.LAM_SUP enables and configures LAM for supervisor pointers:
> • If CR3.LAM_SUP = 0, LAM is not enabled for supervisor pointers.
> • If CR3.LAM_SUP = 1, LAM is enabled for supervisor pointers with a
> width determined by the paging mode:
>
> Based on the context, I think "CR3.LAM_SUP" should be "CR4.LAM_SUP".
>
> I believe it could just be a typo.
Ah, right, I hold the same belief with you. We can report it to ISE
author;-)
> But it is confusing enough.
>
> B.R.
> Yu
next prev parent reply other threads:[~2022-12-21 8:55 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 4:45 [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-09 4:45 ` [PATCH v3 1/9] KVM: x86: Rename cr4_reserved/rsvd_* variables to be more readable Robert Hoo
2022-12-28 3:37 ` Binbin Wu
2022-12-29 1:42 ` Robert Hoo
2023-01-07 0:35 ` Sean Christopherson
2023-01-07 13:30 ` Robert Hoo
2023-01-08 14:18 ` Xiaoyao Li
2023-01-09 3:07 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 2/9] KVM: x86: Add CR4.LAM_SUP in guest owned bits Robert Hoo
2023-01-07 0:38 ` Sean Christopherson
2023-01-07 13:32 ` Robert Hoo
2023-01-09 16:29 ` Sean Christopherson
2023-01-10 3:56 ` Robert Hoo
2023-01-11 17:35 ` Sean Christopherson
2022-12-09 4:45 ` [PATCH v3 3/9] KVM: x86: MMU: Rename get_cr3() --> get_pgd() and clear high bits for pgd Robert Hoo
2022-12-19 6:44 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2023-01-07 0:45 ` Sean Christopherson
2023-01-07 13:36 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 4/9] KVM: x86: MMU: Commets update Robert Hoo
2022-12-09 4:45 ` [PATCH v3 5/9] KVM: x86: MMU: Integrate LAM bits when build guest CR3 Robert Hoo
2022-12-19 6:53 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-21 2:12 ` Yuan Yao
2022-12-21 7:50 ` Yu Zhang
2022-12-21 8:55 ` Robert Hoo [this message]
2022-12-09 4:45 ` [PATCH v3 6/9] KVM: x86: Untag LAM bits when applicable Robert Hoo
2022-12-19 7:32 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-19 9:45 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-21 2:38 ` Yuan Yao
2022-12-21 8:02 ` Yu Zhang
2022-12-21 8:49 ` Robert Hoo
2022-12-21 10:10 ` Yu Zhang
2022-12-21 10:30 ` Yuan Yao
2022-12-21 12:40 ` Yu Zhang
2022-12-22 8:21 ` Yu Zhang
2022-12-23 2:36 ` Yuan Yao
2022-12-23 3:55 ` Robert Hoo
2022-12-21 0:35 ` Yang, Weijiang
2022-12-21 1:38 ` Robert Hoo
2022-12-21 2:55 ` Yuan Yao
2022-12-21 8:22 ` Robert Hoo
2022-12-21 9:35 ` Yuan Yao
2022-12-21 10:22 ` Yu Zhang
2022-12-21 10:33 ` Yuan Yao
2022-12-21 8:14 ` Yu Zhang
2022-12-21 8:37 ` Yu Zhang
2022-12-28 8:32 ` Binbin Wu
2022-12-29 0:41 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 7/9] KVM: x86: When judging setting CR3 valid or not, consider LAM bits Robert Hoo
2022-12-09 4:45 ` [PATCH v3 8/9] KVM: x86: When guest set CR3, handle LAM bits semantics Robert Hoo
2022-12-20 9:10 ` Liu, Jingqi
2022-12-20 14:16 ` Robert Hoo
2022-12-21 8:30 ` Yu Zhang
2022-12-21 12:52 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 9/9] KVM: x86: LAM: Expose LAM CPUID to user space VMM Robert Hoo
2022-12-19 6:12 ` [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-19 8:09 ` Yuan Yao
2022-12-20 14:06 ` Robert Hoo
2022-12-20 9:20 ` Liu, Jingqi
2022-12-20 14:19 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f233bea01059908d3305e77818e2f3f3f158be55.camel@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=jingqi.liu@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=yu.c.zhang@linux.intel.com \
--cc=yuan.yao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox