RE: [PATCH v4 07/17] iommufd: PFN handling for iopt_pages

Tian, Kevin
2022-11-11T11:09:18Z

<...2nd part>

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, November 8, 2022 8:49 AM
> +
> +/* pfn_reader_user is just the pin_user_pages() path */
> +struct pfn_reader_user {
> + struct page **upages;
> + size_t upages_len;
> + unsigned long upages_start;
> + unsigned long upages_end;
> + unsigned int gup_flags;
> + int locked;

document what locked==-1/0/1 means

> +/* This is the "modern" and faster accounting method used by io_uring */

double spaces before 'and'

> +/* Process a single span in the access_itree */

in all storages.