Re: [PATCH v4 04/17] iommufd: Document overview of iommufd

Bagas Sanjaya
2022-11-11T01:46:33Z

On 11/10/22 21:49, Jonathan Corbet wrote:
> So the report you're referring to is
>
> https://lore.kernel.org/linux-next/20221110182938.40ce2651@canb.auug.org.au/
>

Ah, I forget to refer to that link!

> ? If so, this change will not fix the problem. That error:
>
>> drivers/iommu/iommufd/device.c:1: warning: no structured comments found
>> drivers/iommu/iommufd/main.c:1: warning: no structured comments found
>
> is caused by using .. kernel-doc:: directives to extract documentation
> from files where none exists - thus "no structured comments found".
>

-ENOENT files :)

> The *real* problem, methinks, is that the directives are added in patch 4
> of the series, but the documentation doesn't show up until later. So
> the real fix would be to simply move this patch down. Or just not worry
> about it, since it all works out in the end and nobody will be bisecting
> a docs build.
>
> Bagas, you are *again* misadvising people. Please stop doing that!
>

OK, thanks.

--
An old man doll... just what I always wanted! - Clara