Re: [PATCH v4 07/17] iommufd: PFN handling for iopt_pages

Jason Gunthorpe
2022-11-14T17:25:11Z

On Fri, Nov 11, 2022 at 11:09:08AM +0000, Tian, Kevin wrote:
> <...2nd part>
>
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Tuesday, November 8, 2022 8:49 AM
> > +
> > +/* pfn_reader_user is just the pin_user_pages() path */
> > +struct pfn_reader_user {
> > + struct page **upages;
> > + size_t upages_len;
> > + unsigned long upages_start;
> > + unsigned long upages_end;
> > + unsigned int gup_flags;
> > + int locked;
>
> document what locked==-1/0/1 means

+ /*
+ * 1 means mmget() and mmap_read_lock(), 0 means only mmget(), -1 is
+ * neither
+ */

> > +/* Process a single span in the access_itree */
>
> in all storages.

+/* Process a single span to load it from the proper storage */

Thanks,
Jason