public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Christoph Schlameuss <schlameuss@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: vsie: retry SIE when unable to get vsie_page
Date: Mon, 05 Jan 2026 10:46:53 -0500	[thread overview]
Message-ID: <f34d767b2a56fb26526566e43fa355235ee53932.camel@linux.ibm.com> (raw)
In-Reply-To: <8334988f-2caa-4361-b0b9-50b9f41f6d8a@linux.ibm.com>

On Mon, 2026-01-05 at 13:41 +0100, Janosch Frank wrote:
> On 12/17/25 04:01, Eric Farman wrote:
> > SIE may exit because of pending host work, such as handling an interrupt,
> > in which case VSIE rewinds the guest PSW such that it is transparently
> > resumed (see Fixes tag). There is still one scenario where those conditions
> > are not present, but that the VSIE processor returns with effectively rc=0,
> > resulting in additional (and unnecessary) guest work to be performed.
> > 
> > For this case, rewind the guest PSW as we do in the other non-error exits.
> > 
> > Fixes: 33a729a1770b ("KVM: s390: vsie: retry SIE instruction on host intercepts")
> > Signed-off-by: Eric Farman <farman@linux.ibm.com>
> 
> This is purely cosmetic to have all instances look the same, right?

Nope, I can take this path with particularly high I/O loads on the system, which ends up
(incorrectly) sending the intercept to the guest.

  reply	other threads:[~2026-01-05 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17  3:01 [PATCH] KVM: s390: vsie: retry SIE when unable to get vsie_page Eric Farman
2026-01-05 12:41 ` Janosch Frank
2026-01-05 15:46   ` Eric Farman [this message]
2026-01-14  9:50     ` Claudio Imbrenda
2026-01-15 21:17       ` Eric Farman
2026-01-16 15:45         ` Eric Farman
2026-01-16 17:01           ` Claudio Imbrenda
2026-01-19 14:49           ` Janosch Frank
2026-01-20 15:23             ` Eric Farman
2026-01-14  9:39 ` Christoph Schlameuss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f34d767b2a56fb26526566e43fa355235ee53932.camel@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schlameuss@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox