From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Mohammed Gamal <mgamal@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org
Subject: Re: [PATCH v3 7/9] KVM: VMX: Add guest physical address check in EPT violation and misconfig
Date: Mon, 17 Aug 2020 20:01:00 +0200 [thread overview]
Message-ID: <f3595331-07e2-55d8-d390-4f421d8e5561@redhat.com> (raw)
In-Reply-To: <20200817172233.GF22407@linux.intel.com>
On 17/08/20 19:22, Sean Christopherson wrote:
>> This splats when running the PKU unit test, although the test still passed.
>> I haven't yet spent the brain power to determine if this is a benign warning,
>> i.e. simply unexpected, or if permission_fault() fault truly can't handle PK
>> faults.
It's more or less unexpected; the error is in the caller. This is not
an error code but an access mask so only U/F/W bits are valid. Patch
sent, thanks.
Paolo
>> WARNING: CPU: 25 PID: 5465 at arch/x86/kvm/mmu.h:197 paging64_walk_addr_generic+0x594/0x750 [kvm]
>> Hardware name: Intel Corporation WilsonCity/WilsonCity, BIOS WLYDCRB1.SYS.0014.D62.2001092233 01/09/2020
>> RIP: 0010:paging64_walk_addr_generic+0x594/0x750 [kvm]
>> Code: <0f> 0b e9 db fe ff ff 44 8b 43 04 4c 89 6c 24 30 8b 13 41 39 d0 89
>> RSP: 0018:ff53778fc623fb60 EFLAGS: 00010202
>> RAX: 0000000000000001 RBX: ff53778fc623fbf0 RCX: 0000000000000007
>> RDX: 0000000000000001 RSI: 0000000000000002 RDI: ff4501efba818000
>> RBP: 0000000000000020 R08: 0000000000000005 R09: 00000000004000e7
>> R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000007
>> R13: ff4501efba818388 R14: 10000000004000e7 R15: 0000000000000000
>> FS: 00007f2dcf31a700(0000) GS:ff4501f1c8040000(0000) knlGS:0000000000000000
>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 0000000000000000 CR3: 0000001dea475005 CR4: 0000000000763ee0
>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>> PKRU: 55555554
>> Call Trace:
>> paging64_gva_to_gpa+0x3f/0xb0 [kvm]
>> kvm_fixup_and_inject_pf_error+0x48/0xa0 [kvm]
>> handle_exception_nmi+0x4fc/0x5b0 [kvm_intel]
>> kvm_arch_vcpu_ioctl_run+0x911/0x1c10 [kvm]
>> kvm_vcpu_ioctl+0x23e/0x5d0 [kvm]
>> ksys_ioctl+0x92/0xb0
>> __x64_sys_ioctl+0x16/0x20
>> do_syscall_64+0x3e/0xb0
>> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>> ---[ end trace d17eb998aee991da ]---
>
> Looks like this series got pulled for 5.9, has anyone looked into this?
>
next prev parent reply other threads:[~2020-08-17 18:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 15:48 [PATCH v3 0/9] KVM: Support guest MAXPHYADDR < host MAXPHYADDR Mohammed Gamal
2020-07-10 15:48 ` [PATCH v3 1/9] KVM: x86: Add helper functions for illegal GPA checking and page fault injection Mohammed Gamal
2020-07-10 15:48 ` [PATCH v3 2/9] KVM: x86: mmu: Move translate_gpa() to mmu.c Mohammed Gamal
2020-07-10 15:48 ` [PATCH v3 3/9] KVM: x86: mmu: Add guest physical address check in translate_gpa() Mohammed Gamal
2020-07-10 17:41 ` Paolo Bonzini
2020-07-10 15:48 ` [PATCH v3 4/9] KVM: x86: rename update_bp_intercept to update_exception_bitmap Mohammed Gamal
2020-07-10 16:15 ` Jim Mattson
2020-07-10 15:48 ` [PATCH v3 5/9] KVM: x86: update exception bitmap on CPUID changes Mohammed Gamal
2020-07-10 16:25 ` Jim Mattson
2020-07-10 15:48 ` [PATCH v3 6/9] KVM: VMX: introduce vmx_need_pf_intercept Mohammed Gamal
2020-07-10 15:48 ` [PATCH v3 7/9] KVM: VMX: Add guest physical address check in EPT violation and misconfig Mohammed Gamal
2020-07-13 18:32 ` Sean Christopherson
2020-07-15 23:00 ` Sean Christopherson
2020-08-17 17:22 ` Sean Christopherson
2020-08-17 18:01 ` Paolo Bonzini [this message]
2020-10-09 16:17 ` Jim Mattson
2020-10-14 23:44 ` Jim Mattson
2020-10-23 3:14 ` Sean Christopherson
2020-10-23 9:22 ` Paolo Bonzini
2020-10-23 16:59 ` Jim Mattson
2020-10-23 17:16 ` Paolo Bonzini
2020-10-23 17:23 ` Jim Mattson
2020-10-23 17:43 ` Paolo Bonzini
2021-01-15 19:35 ` Jim Mattson
2021-01-20 21:16 ` Jim Mattson
2021-01-27 20:57 ` Jim Mattson
2021-06-21 18:31 ` Jim Mattson
2020-07-10 15:48 ` [PATCH v3 8/9] KVM: VMX: optimize #PF injection when MAXPHYADDR does not match Mohammed Gamal
2020-07-10 15:48 ` [PATCH v3 9/9] KVM: x86: SVM: VMX: Make GUEST_MAXPHYADDR < HOST_MAXPHYADDR support configurable Mohammed Gamal
2020-07-10 17:40 ` Paolo Bonzini
2020-07-10 16:30 ` [PATCH v3 0/9] KVM: Support guest MAXPHYADDR < host MAXPHYADDR Jim Mattson
2020-07-10 17:06 ` Paolo Bonzini
2020-07-10 17:13 ` Jim Mattson
2020-07-10 17:16 ` Paolo Bonzini
2020-07-10 17:26 ` Sean Christopherson
2020-07-10 17:26 ` Jim Mattson
2020-07-10 17:40 ` Paolo Bonzini
2020-07-10 17:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3595331-07e2-55d8-d390-4f421d8e5561@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox