From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0FDBC433E7 for ; Thu, 16 Jul 2020 20:38:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B624F2083B for ; Thu, 16 Jul 2020 20:38:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T9b0uCV3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbgGPUij (ORCPT ); Thu, 16 Jul 2020 16:38:39 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:22587 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726656AbgGPUij (ORCPT ); Thu, 16 Jul 2020 16:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594931917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/CjDuk4zdnGXZCpAX8XmulZKhmJ4OnT0I1eZkf+SUbg=; b=T9b0uCV3wMWz0Q0CtVN7Do7uNgqyEv3254fRLMlgG2EGDahFGZZjjeQeKmWpL+w2ljKwqG v1wWh6hu89hAiUz+ufn+1gobWEeL+W8Xq1QQgc1E5USmqxjgfuHN7F/GUl0Ohx4A238PGR oFKOOWmXCLKefLd9fQnCqn3VAWxjpMg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-wzxDx8tPOE-ErPFAnGdpTg-1; Thu, 16 Jul 2020 16:38:34 -0400 X-MC-Unique: wzxDx8tPOE-ErPFAnGdpTg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE1E218A1DFD; Thu, 16 Jul 2020 20:38:31 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2616775540; Thu, 16 Jul 2020 20:38:19 +0000 (UTC) Subject: Re: [PATCH v5 03/15] iommu/smmu: Report empty domain nesting info To: Jean-Philippe Brucker , "Liu, Yi L" Cc: Will Deacon , "alex.williamson@redhat.com" , "baolu.lu@linux.intel.com" , "joro@8bytes.org" , "Tian, Kevin" , "jacob.jun.pan@linux.intel.com" , "Raj, Ashok" , "Tian, Jun J" , "Sun, Yi Y" , "peterx@redhat.com" , "Wu, Hao" , "stefanha@gmail.com" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Robin Murphy References: <1594552870-55687-1-git-send-email-yi.l.liu@intel.com> <1594552870-55687-4-git-send-email-yi.l.liu@intel.com> <20200713131454.GA2739@willie-the-truck> <20200716153959.GA447208@myrica> From: Auger Eric Message-ID: Date: Thu, 16 Jul 2020 22:38:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200716153959.GA447208@myrica> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Jean, On 7/16/20 5:39 PM, Jean-Philippe Brucker wrote: > On Tue, Jul 14, 2020 at 10:12:49AM +0000, Liu, Yi L wrote: >>> Have you verified that this doesn't break the existing usage of >>> DOMAIN_ATTR_NESTING in drivers/vfio/vfio_iommu_type1.c? >> >> I didn't have ARM machine on my hand. But I contacted with Jean >> Philippe, he confirmed no compiling issue. I didn't see any code >> getting DOMAIN_ATTR_NESTING attr in current drivers/vfio/vfio_iommu_type1.c. >> What I'm adding is to call iommu_domai_get_attr(, DOMAIN_ATTR_NESTIN) >> and won't fail if the iommu_domai_get_attr() returns 0. This patch >> returns an empty nesting info for DOMAIN_ATTR_NESTIN and return >> value is 0 if no error. So I guess it won't fail nesting for ARM. > > I confirm that this series doesn't break the current support for > VFIO_IOMMU_TYPE1_NESTING with an SMMUv3. That said... > > If the SMMU does not support stage-2 then there is a change in behavior > (untested): after the domain is silently switched to stage-1 by the SMMU > driver, VFIO will now query nesting info and obtain -ENODEV. Instead of > succeding as before, the VFIO ioctl will now fail. I believe that's a fix > rather than a regression, it should have been like this since the > beginning. No known userspace has been using VFIO_IOMMU_TYPE1_NESTING so > far, so I don't think it should be a concern. But as Yi mentioned ealier, in the current vfio code there is no DOMAIN_ATTR_NESTING query yet. In my SMMUV3 nested stage series, I added such a query in vfio-pci.c to detect if I need to expose a fault region but I already test both the returned value and the output arg. So to me there is no issue with that change. > > And if userspace queries the nesting properties using the new ABI > introduced in this patchset, it will obtain an empty struct. I think > that's acceptable, but it may be better to avoid adding the nesting cap if > @format is 0? agreed Thanks Eric > > Thanks, > Jean > >> >> @Eric, how about your opinion? your dual-stage vSMMU support may >> also share the vfio_iommu_type1.c code. >> >> Regards, >> Yi Liu >> >>> Will >