Re: [kvm-unit-tests PATCH v2 5/5] Use report_pass(...) instead of report(1/true, ...)

[Thomas Huth <thuth@redhat.com>]

On 05/10/2021 11.09, Janis Schoetterl-Glausch wrote:
> Whitespace is kept consistent with the rest of the file.
> 
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> ---
>   s390x/css.c         |  4 ++--
>   s390x/diag288.c     |  2 +-
>   s390x/selftest.c    |  2 +-
>   s390x/smp.c         | 16 ++++++++--------
>   s390x/spec_ex.c     |  7 +++----
>   x86/asyncpf.c       |  7 +++----
>   x86/emulator.c      |  2 +-
>   x86/hyperv_stimer.c | 18 ++++++++----------
>   x86/svm_tests.c     | 17 ++++++++---------
>   x86/syscall.c       |  2 +-
>   x86/taskswitch2.c   |  2 +-
>   x86/tsc_adjust.c    |  2 +-
>   x86/vmx.c           |  6 +++---
>   x86/vmx_tests.c     | 36 ++++++++++++++++++------------------
>   14 files changed, 59 insertions(+), 64 deletions(-)
> 
> diff --git a/s390x/css.c b/s390x/css.c
> index dcb4d70..881206b 100644
> --- a/s390x/css.c
> +++ b/s390x/css.c
> @@ -31,7 +31,7 @@ static void test_enumerate(void)
>   {
>   	test_device_sid = css_enumerate();
>   	if (test_device_sid & SCHID_ONE) {
> -		report(1, "Schid of first I/O device: 0x%08x", test_device_sid);
> +		report_pass("Schid of first I/O device: 0x%08x", test_device_sid);
>   		return;
>   	}
...

Thanks, I've applied patches 3 - 5 now to the repository, since there were 
no objections and they are independent from your spec_ex work. (Dropped the 
hunk to spec_ex.c here of course, so please integrate that in the next 
version of that patch directly instead).

  Thomas