From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH] x86: fix ept_access_test_paddr exit qualifications Date: Fri, 12 May 2017 10:43:49 +0200 Message-ID: References: <20170505205723.39601-1-dmatlack@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: David Matlack , kvm@vger.kernel.org Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35131 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755196AbdELInz (ORCPT ); Fri, 12 May 2017 04:43:55 -0400 Received: by mail-wm0-f68.google.com with SMTP id v4so12324927wmb.2 for ; Fri, 12 May 2017 01:43:54 -0700 (PDT) In-Reply-To: <20170505205723.39601-1-dmatlack@google.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 05/05/2017 22:57, David Matlack wrote: > static void ept_access_test_paddr_read_only_ad_disabled(void) > { > - u64 qual = EPT_VLT_WR | EPT_VLT_PERM_RD; > + u64 qual = EPT_VLT_WR | EPT_VLT_RD | EPT_VLT_PERM_RD; So this patch *was* correct after all. Sorry. :) I've added a comment here and in ept_access_test_paddr_read_execute_ad_disabled: /* * When EPT AD bits are disabled, all accesses to guest paging * structures are reported separately as a read and (after * translation of the GPA to host physical address) a read+write * if the A/D bits have to be set. */ then squashed everything and pushed to kvm-unit-tests.git master branch. Thanks again! Paolo