From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH RFC 4/4] VMX: Expose the LA57 feature to VM
Date: Thu, 9 Mar 2017 16:16:37 +0100
Message-ID: <f76f9689-4712-94a0-e620-d16c5c1b6b75@redhat.com>
References: <1483003563-25847-1-git-send-email-liang.z.li@intel.com>
 <1483003563-25847-5-git-send-email-liang.z.li@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com,
        guangrong.xiao@linux.intel.com, rkrcmar@redhat.com
To: Liang Li <liang.z.li@intel.com>, kvm@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1483003563-25847-5-git-send-email-liang.z.li@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 29/12/2016 10:26, Liang Li wrote:
> -		if (is_noncanonical_address(la))
> +		if (is_noncanonical_address(la, virt_addr_bits(ctxt)))

Using virt_addr_bits and get_virt_addr_bits is quite a mouthful.  What
about using instead a pair of functions like these:

bool is_noncanonical_address(struct kvm_vcpu *vcpu, u64 addr)
{
	return addr == get_canonical(addr, get_virt_addr_bits(vcpu));
}

bool emulate_is_noncanonical_address(struct x86_emulate_ctxt *ctxt,
				     u64 addr)
{
	return addr == get_canonical(addr, virt_addr_bits(ctxt));
}


Paolo