Re: [PATCH v1 3/3] kernel/configs: don't include PCI_QUIRKS in KVM guest configs

Alex Bennée
2020-08-04T14:45:27Z

Marc Zyngier <maz@kernel.org> writes:

> On 2020-08-04 13:44, Alex Bennée wrote:
>> The VIRTIO_PCI support is an idealised PCI bus, we don't need a bunch
>> of bloat for real world hardware for a VirtIO guest.
>
> Who says this guest will only have virtio devices?

This is true - although what is the point of kvm_guest.config? We
certainly turn on a whole bunch of virt optimised pathways with PARAVIRT
and HYPERVISOR_GUEST along with the rest of VirtIO.

> Or even, virtio devices without bugs? Given that said device can
> come from any VMM, I'm not sure this is the right thing to do.

Perhaps this patch is one too far. I don't mind dropping it as long as I
can still slim down the kernels I know don't need the extra bloat.

>
> Thanks,
>
> M.
>
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> kernel/configs/kvm_guest.config | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/configs/kvm_guest.config
>> b/kernel/configs/kvm_guest.config
>> index 208481d91090..672863a2fdf1 100644
>> --- a/kernel/configs/kvm_guest.config
>> +++ b/kernel/configs/kvm_guest.config
>> @@ -13,6 +13,7 @@ CONFIG_IP_PNP_DHCP=y
>> CONFIG_BINFMT_ELF=y
>> CONFIG_PCI=y
>> CONFIG_PCI_MSI=y
>> +CONFIG_PCI_QUIRKS=n
>> CONFIG_DEBUG_KERNEL=y
>> CONFIG_VIRTUALIZATION=y
>> CONFIG_HYPERVISOR_GUEST=y

--
Alex Bennée