From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging Date: Thu, 4 May 2017 11:21:29 +0200 Message-ID: References: <20170503221457.18869-1-bsd@redhat.com> <20170503221457.18869-3-bsd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org To: Bandan Das , kvm@vger.kernel.org Return-path: In-Reply-To: <20170503221457.18869-3-bsd@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/05/2017 00:14, Bandan Das wrote: > + if (vmx->nested.pml_full) { > + exit_reason = EXIT_REASON_PML_FULL; > + vmx->nested.pml_full = false; > + } else if (fault->error_code & PFERR_RSVD_MASK) > exit_reason = EXIT_REASON_EPT_MISCONFIG; > else > exit_reason = EXIT_REASON_EPT_VIOLATION; > + /* > + * The definition of bit 12 for EPT violations and PML > + * full event is the same, so pass it through since > + * the rest of the bits are undefined. > + */ Please zero all other bits instead. It's as easy as adding an "u64 exit_qualification" local variable. Paolo > nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);