Re: [PATCH v3 16/16] perf: Drop guest callback (un)register stubs

Paolo Bonzini
2021-09-22T06:29:26Z

On 22/09/21 02:05, Sean Christopherson wrote:
> Drop perf's stubs for (un)registering guest callbacks now that KVM
> registration of callbacks is hidden behind GUEST_PERF_EVENTS=y. The only
> other user is x86 XEN_PV, and x86 unconditionally selects PERF_EVENTS.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
> include/linux/perf_event.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index d582dfeb4e20..20327d1046bb 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1505,11 +1505,6 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { }
> static inline void
> perf_bp_event(struct perf_event *event, void *data) { }
>
> -static inline void perf_register_guest_info_callbacks
> -(struct perf_guest_info_callbacks *cbs) { }
> -static inline void perf_unregister_guest_info_callbacks
> -(struct perf_guest_info_callbacks *cbs) { }
> -
> static inline void perf_event_mmap(struct vm_area_struct *vma) { }
>
> typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data);
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>