Re: [kvm-unit-tests GIT PULL 00/18] s390x: new edat, diag258 and STFLE tests; fixes for genprotimg >= 2.36.0; cleanups for snippets and makefiles

[Thomas Huth <thuth@redhat.com>]

On 03/02/2025 09.35, Nico Boehr wrote:
> Hi Paolo and/or Thomas,
> 
> Changes in this pull request:
> - cpacf query function were reworked in the kernel, that fix was
>    cherry-picked by Nina. This fixes issues with possible incorrect
>    instruction format
> - Claudio extended the edat test for a special case with a 2G page at
>    the end of memory to ensure the correct addressing exception happens.
> - I added a test for diag258 where we had some issues with
>    virtual-physical address confusion.
> - Nina took the time to add library functions that help exiting from a
>    snippet s390x.
> - Nina contributed a test for STFLE interpretive execution. Thank you!
> - Marc did a lot of magic fixing issues in our Makefiles. This fixes
>    several issues with out-of-tree-builds. We now also build out-of-tree
>    in our downstream CI to avoid unpleasant surprises for maintainers :)
>    Marc, thanks for contributing your Makefile knowledge and for turning my
>    complaints into something productive
> - Janosch also invested some time to clean up snippets and Makefiles,
>    which made the code a lot nicer, thanks for that as well!
> - we have a compatibility issue with genprotimg
>    versions >= 2.36.0. Thanks Marc to fixing that. You should upgrade
>    kvm-unit-tests if you use genprotimg >= 2.36.0!
> 
> Note that there are two checkpatch errors:
>> ERROR: space prohibited before that ':' (ctx:WxW)
> I would suggest to ignore them, the code really looks ugly otherwise.
> 
> Thanks
> Nico

Thanks, merged now.

  Thomas