From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBD817F4F5 for ; Tue, 25 Jun 2024 23:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719358458; cv=none; b=atCAg0Wb6FhupXMrl98N2eCpElVjfyKIRcnq5RmSUUuN3P1iPx9x2q4hadMsMk1F+MZf+wk4js6kb2tmyDhauk5KresUcwArUDYnAQBrMcxlMQm60yUaQRPpJhU3Ma2onXEdmxDuCsWDGd98oMHepi3R8fAG7AHawgYl8R92Y8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719358458; c=relaxed/simple; bh=JW5+38U/vcohXyeiKPUGkpLsj7sweQrd3uPWwGSP2dA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PeT5FvlGv0EKPEAUyzs1ZiArdy23nzQ0J1Oois1L+i5TGTRzUboFTYjU2/eWIwq5/cNHe/DUiTktLBwCz5ACXypiaBzcxS91Ie5CTKOAIg8z0NKFHDidWpgLy4WRqKqI7WNfffBA5G3wkKAiBFWgVHlcQXXG5vuz2z4pfim/W+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=V/wG5oku; arc=none smtp.client-ip=209.85.166.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="V/wG5oku" Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3745eb24ffaso3359785ab.1 for ; Tue, 25 Jun 2024 16:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1719358455; x=1719963255; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fLoxHe91BqYGbErrOqOVZAihyCRQ1/q/QL1BRJCrC+o=; b=V/wG5okuWv18Vfa9pCOLL2nMRWl0biru0lnT4hzlLivPncC8sUFRvm6gMENvRd81ux QxzPGLVY1A39TY2Xzr/l8CPnCCX9uwuvpizox9qSO1liYdMtH4JUSn4TZnVi60Ig1RYx IIvjxXMb9wbIZszaG50NROd83GnyXknc7sdyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719358455; x=1719963255; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fLoxHe91BqYGbErrOqOVZAihyCRQ1/q/QL1BRJCrC+o=; b=gS4EmXSEO3ENr1Sy7yClXq6f3ks+0SZ1hsi/00ywCT3rMKccAfLSXdA23nQjTcq5LN RmENDPg5pOZPm04wZEzT9sIEiz0oG5Cz2Y0XRSw58TO6TEe6M5Y5Wk7TejUBzmPDT8OF Xl+evtuLr9hFhUaP8YkHHiEt9p8KNKhT7Qaz5tQQB8vL8yt1UG2UsN72XFCFUUOry9fz ZAylSfHTlVwtRC3xbJ5mKLjpXXBdsaqa1/Fq/ejYmkt6VvtVQehXTA8+nuoH1PH8PlN/ 5s1yiWxfRGD9kTjZXmmqkm1X4aeKgdeQ7YOweh5Cl/Q8+GSnHayEo+niMjLfNCwOtp0W t2Dw== X-Forwarded-Encrypted: i=1; AJvYcCX3lNCDFuAYUgTPc/9uB+Xrznd7sysMhm9mxqFQHJtKrmb9oFcj0wCBQjXh95443eweifwBQ0UZ03T112l4XtBbse1A X-Gm-Message-State: AOJu0YwiM87Guu/Zt4GRFfV2EoZBHADK3VETqTKVSHuMf2DKK+4ivJs0 75HLjGvHbIFlGnK/C6KvUliscq4ciu/+7yTnxae0ZxPlOXIUDL6qd5kTiJ0cIn0= X-Google-Smtp-Source: AGHT+IHFxsdnrHHCJW39/Lbu9cUGENC+vnEtRYVDBjLq63CwNtPtBkCUmNgYxOl/tyW+mRbcBoYz8w== X-Received: by 2002:a05:6602:3148:b0:7f3:9ef8:30a4 with SMTP id ca18e2360f4ac-7f39ef8334dmr991110139f.1.1719358455001; Tue, 25 Jun 2024 16:34:15 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb458ba8efsm645345173.8.2024.06.25.16.34.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 16:34:14 -0700 (PDT) Message-ID: Date: Tue, 25 Jun 2024 17:34:13 -0600 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/13] Centralize _GNU_SOURCE definition into lib.mk To: Andrew Morton , Edward Liaw Cc: linux-kselftest@vger.kernel.org, Eric Biederman , Kees Cook , Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jason Gunthorpe , Kevin Tian , Paolo Bonzini , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Fenghua Yu , Reinette Chatre , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jarkko Sakkinen , Dave Hansen , linux-kernel@vger.kernel.org, usama.anjum@collabora.com, seanjc@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sgx@vger.kernel.org, Shuah Khan References: <20240624232718.1154427-1-edliaw@google.com> <20240625135234.d52ef77c0d84cb19d37dc44f@linux-foundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240625135234.d52ef77c0d84cb19d37dc44f@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/25/24 14:52, Andrew Morton wrote: > On Mon, 24 Jun 2024 23:26:09 +0000 Edward Liaw wrote: > >> Centralizes the definition of _GNU_SOURCE into lib.mk and addresses all >> resulting macro redefinition warnings. >> >> These patches will need to be merged in one shot to avoid redefinition >> warnings. > > Yes, please do this as a single patch and resend? Since the change is limited to makefiles and one source file we can manage it with one patch. Please send single patch and I will apply to next and we can resolve conflicts if any before the merge window rolls around. thanks, -- Shuah