From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"nikunj@amd.com" <nikunj@amd.com>
Cc: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"santosh.shukla@amd.com" <santosh.shukla@amd.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v2 2/4] KVM: x86: Move PML page to common vcpu arch structure
Date: Tue, 16 Sep 2025 10:27:05 +0000 [thread overview]
Message-ID: <fa0e2f42a505756166f4676220eff553c00efb1e.camel@intel.com> (raw)
In-Reply-To: <20250915085938.639049-3-nikunj@amd.com>
On Mon, 2025-09-15 at 08:59 +0000, Nikunj A Dadhania wrote:
> Move the PML page from VMX-specific vcpu_vmx structure to the common
> kvm_vcpu_arch structure to share it between VMX and SVM implementations.
>
> Update all VMX references accordingly, and simplify the
> kvm_flush_pml_buffer() interface by removing the page parameter since it
> can now access the page directly from the vcpu structure.
>
> No functional change, restructuring to prepare for SVM PML support.
>
> Suggested-by: Kai Huang <kai.huang@intel.com>
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Nit: IMHO it's also better to explain why we only moved the PML buffer
pointer but not the code which allocates/frees the PML buffer:
Move the PML page to x86 common code only without moving the PML page
allocation code, since for AMD the PML buffer must be allocated using
snp_safe_alloc_page().
next prev parent reply other threads:[~2025-09-16 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 8:59 [PATCH v2 0/4] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2025-09-15 8:59 ` [PATCH v2 1/4] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2025-09-15 8:59 ` [PATCH v2 2/4] KVM: x86: Move PML page to common vcpu arch structure Nikunj A Dadhania
2025-09-16 10:27 ` Huang, Kai [this message]
2025-09-17 3:31 ` Nikunj A. Dadhania
2025-09-17 10:13 ` Huang, Kai
2025-09-17 10:17 ` Nikunj A. Dadhania
2025-09-17 10:28 ` Huang, Kai
2025-09-15 8:59 ` [PATCH v2 3/4] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2025-09-15 8:59 ` [PATCH v2 4/4] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2025-09-15 12:35 ` Huang, Kai
2025-09-18 6:12 ` Nikunj A Dadhania
2025-09-24 6:26 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0e2f42a505756166f4676220eff553c00efb1e.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox