From: Tao Cui <cui.tao@linux.dev>
To: Bibo Mao <maobibo@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>
Cc: cui.tao@linux.dev, WANG Xuerui <kernel@xen0n.name>,
kvm@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] LoongArch: KVM: Code cleanup with MSI intterupt injection
Date: Thu, 10 Sep 2026 11:06:02 +0800 [thread overview]
Message-ID: <fb08279a-eb1b-44b1-b4af-f354fb81f112@linux.dev> (raw)
In-Reply-To: <20260909083259.1910290-1-maobibo@loongson.cn>
Hi, Bibo
在 2026/9/9 16:32, Bibo Mao 写道:
> Here is to remove some unnecessary parameter checking when injecting
> MSI interrupt, include MSI level parameter and vcpu::arch::dmsintc_state
> NULL pointer etc.
>
> Bibo Mao (2):
> LoongArch: KVM: Remove parameter line when inject MSI
> LoongArch: KVM: Remove duplicated checking with DMSI irq injection
>
> arch/loongarch/include/asm/kvm_dmsintc.h | 3 +--
> arch/loongarch/include/asm/kvm_pch_pic.h | 2 +-
> arch/loongarch/kvm/intc/dmsintc.c | 19 +++----------------
> arch/loongarch/kvm/intc/pch_pic.c | 6 +++---
> arch/loongarch/kvm/irqfd.c | 6 +++---
> 5 files changed, 11 insertions(+), 25 deletions(-)
>
>
> base-commit: df2908090cda368b01ff43709f51890076c56157
The series looks good to me.
Reviewed-by: Tao Cui <cuitao@kylinos.cn>
Minor question: kvm_set_msi() now returns -EINVAL for !level instead
of -1. Since MSI is edge-triggered, returning 0 to ignore a deassert
would also work, though nothing looks at the return value today.
prev parent reply other threads:[~2026-09-10 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:32 [PATCH 0/2] LoongArch: KVM: Code cleanup with MSI intterupt injection Bibo Mao
2026-09-09 8:32 ` [PATCH 1/2] LoongArch: KVM: Remove parameter line when inject MSI Bibo Mao
2026-09-09 8:32 ` [PATCH 2/2] LoongArch: KVM: Remove duplicated checking with DMSI irq injection Bibo Mao
2026-09-10 3:06 ` Tao Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb08279a-eb1b-44b1-b4af-f354fb81f112@linux.dev \
--to=cui.tao@linux.dev \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox