From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816A4C433F5 for ; Wed, 8 Dec 2021 07:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244535AbhLHHhM (ORCPT ); Wed, 8 Dec 2021 02:37:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:60351 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbhLHHhL (ORCPT ); Wed, 8 Dec 2021 02:37:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638948819; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VaQgBFKDWPtyW4rX+GpfnPjaazD4SfZz/ToOHd0Wuzc=; b=YU2eE5Zy2pdmBM5UwvMsJw2CCDMctOfUiBbeZ/EzC6oggS6rnguVStrUu6EscRL/svVa+u 0e+ezvm2vuxcmBCCLIpGBwrKIG1Te74Km5WvIyZ5ooklHPObyJHZz8b8jdAOG7RaTeND9R yGglM4KnwkZKlRKa6+5ZysRhJNXTw0Y= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-51-cJn4B6w4NTarZ6iI4nXc2g-1; Wed, 08 Dec 2021 02:33:37 -0500 X-MC-Unique: cJn4B6w4NTarZ6iI4nXc2g-1 Received: by mail-wm1-f72.google.com with SMTP id v62-20020a1cac41000000b0033719a1a714so869862wme.6 for ; Tue, 07 Dec 2021 23:33:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=VaQgBFKDWPtyW4rX+GpfnPjaazD4SfZz/ToOHd0Wuzc=; b=fniPGMSWOwCl6CBA/pvWa7rYq7j7ntrYKGSEoIEEQox0nmBertjSBkepeYnPDkhTNQ so+bFisMWfDAXKgP3bXsdUJ591lqcYdzVLu6sPFaBMlGzEzHTx7EKu4ivVsGhnPYmh53 fzP+hKSjjI3l+ZEnf3kOX/lEeZ4EsB3d363rbmgIfWZDYSv1V4stI5/PVaSFGd1DayGm PCHp7kbBWg5UTyzfwaQYqgt22rnyOWCeLSFmUWHjJP3WzRSrOmR4Li8plSP+HDSJ3Cau MOVZFEKt/2IHqNYKXTrUNIWSWq9DdR8tbmH8BVmexSImSF9OPBxTgmVgGjLT2qT5hRlv otxw== X-Gm-Message-State: AOAM531A2ImobJOIUFMmVoLJJfOxmM/dnF1U2hlKA+9Ypn86HFgarLmj zxIJN3rs8M01p+O7Ks/x4RJa+oRVtWAK9q8Mw5RL9m69joMnYu8t9G5EJ5hf/pho33h8o0C6dUG 3Gc8O6gyjnSbF X-Received: by 2002:adf:f708:: with SMTP id r8mr57333461wrp.198.1638948816619; Tue, 07 Dec 2021 23:33:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7KoV5p8PVF3If5VE3e/tXMfPoPdiN58LX+mhb+Qk/apSQFS8E5N4maEwm2dxUTEGR+YL9hQ== X-Received: by 2002:adf:f708:: with SMTP id r8mr57333432wrp.198.1638948816394; Tue, 07 Dec 2021 23:33:36 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id l3sm2033529wmq.46.2021.12.07.23.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 23:33:35 -0800 (PST) Reply-To: eric.auger@redhat.com Subject: Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API To: Lu Baolu , Joerg Roedel Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, vivek.gautam@arm.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com, jean-philippe@linaro.org, ashok.raj@intel.com, maz@kernel.org, vsethi@nvidia.com, zhangfei.gao@linaro.org, kevin.tian@intel.com, will@kernel.org, alex.williamson@redhat.com, wangxingang5@huawei.com, linux-kernel@vger.kernel.org, lushenming@huawei.com, iommu@lists.linux-foundation.org, robin.murphy@arm.com, Jason Gunthorpe References: <20211027104428.1059740-1-eric.auger@redhat.com> <20211027104428.1059740-2-eric.auger@redhat.com> From: Eric Auger Message-ID: Date: Wed, 8 Dec 2021 08:33:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Baolu, On 12/8/21 3:44 AM, Lu Baolu wrote: > Hi Eric, > > On 12/7/21 6:22 PM, Eric Auger wrote: >> On 12/6/21 11:48 AM, Joerg Roedel wrote: >>> On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote: >>>> Signed-off-by: Jean-Philippe Brucker >>>> Signed-off-by: Liu, Yi L >>>> Signed-off-by: Ashok Raj >>>> Signed-off-by: Jacob Pan >>>> Signed-off-by: Eric Auger >>> This Signed-of-by chain looks dubious, you are the author but the last >>> one in the chain? >> The 1st RFC in Aug 2018 >> (https://lists.cs.columbia.edu/pipermail/kvmarm/2018-August/032478.html) >> said this was a generalization of Jacob's patch >> >> >>    [PATCH v5 01/23] iommu: introduce bind_pasid_table API function >> >> >>    >> https://lists.linuxfoundation.org/pipermail/iommu/2018-May/027647.html >> >> So indeed Jacob should be the author. I guess the multiple rebases got >> this eventually replaced at some point, which is not an excuse. Please >> forgive me for that. >> Now the original patch already had this list of SoB so I don't know if I >> shall simplify it. > > As we have decided to move the nested mode (dual stages) implementation > onto the developing iommufd framework, what's the value of adding this > into iommu core? The iommu_uapi_attach_pasid_table uapi should disappear indeed as it is is bound to be replaced by /dev/iommu fellow API. However until I can rebase on /dev/iommu code I am obliged to keep it to maintain this integration, hence the RFC. Thanks Eric > > Best regards, > baolu >