Re: [kvm-unit-tests PATCH v9 11/12] s390x: css: msch, enable test

Thomas Huth
2020-06-16T11:43:48Z

On 15/06/2020 11.32, Pierre Morel wrote:
> A second step when testing the channel subsystem is to prepare a channel
> for use.
> This includes:
> - Get the current subchannel Information Block (SCHIB) using STSCH
> - Update it in memory to set the ENABLE bit
> - Tell the CSS that the SCHIB has been modified using MSCH
> - Get the SCHIB from the CSS again to verify that the subchannel is
> enabled.
> - If the command succeeds but subchannel is not enabled retry a
> predefined retries count.
> - If the command fails, report the failure and do not retry, even
> if cc indicates a busy/status pending as we do not expect this.
>
> This tests the MSCH instruction to enable a channel succesfuly.

s/succesfuly/successfully/

> This some retries are done and in case of error, and if the retries
> count is exceeded, a report is made.

That sentence needs some fixes, too ;-)

With the commit description fixed:

Acked-by: Thomas Huth <thuth@redhat.com>