Re: [kvm-unit-tests PATCH v9 09/12] s390x: Library resources for CSS tests

Cornelia Huck
2020-06-17T08:43:10Z

On Tue, 16 Jun 2020 12:31:40 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 15/06/2020 11.31, Pierre Morel wrote:
> > Provide some definitions and library routines that can be used by
> > tests targeting the channel subsystem.
> >
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---
> > lib/s390x/css.h | 256 +++++++++++++++++++++++++++++++++++++++++++
> > lib/s390x/css_dump.c | 153 ++++++++++++++++++++++++++
> > s390x/Makefile | 1 +
> > 3 files changed, 410 insertions(+)
> > create mode 100644 lib/s390x/css.h
> > create mode 100644 lib/s390x/css_dump.c
>
> I can't say much about the gory IO details, but at least the inline
> assembly looks fine to me now.
>
> Acked-by: Thomas Huth <thuth@redhat.com>

I've looked at the gory I/O details, and they seem fine to me.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>