Re: [kvm-unit-tests PATCH v9 04/12] s390x: interrupt registration

Pierre Morel
2020-06-17T11:01:53Z

On 2020-06-17 10:20, Cornelia Huck wrote:
> On Mon, 15 Jun 2020 11:31:53 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
> Subject: "s390: I/O interrupt registration" ?

yes, better.

>
>> Let's make it possible to add and remove a custom io interrupt handler,
>> that can be used instead of the normal one.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

...snip...

>> +int unregister_io_int_func(void (*f)(void))
>> +{
>> + if (io_int_func != f)
>> + return -1;
>
> Not sure if we really need these checks, but they don't hurt, either.

Not sure neither but I prefer to let it here to avoid more discussions
since already reviewed-by...

>
>> + io_int_func = NULL;
>> + return 0;
>> +}
>> +
>> void handle_svc_int(void)
>> {
>> report_abort("Unexpected supervisor call interrupt: on cpu %d at %#lx",
>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
>

Thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen