Re: [kvm-unit-tests PATCH v9 01/12] s390x: Use PSW bits definitions in cstart

Pierre Morel
2020-06-16T16:08:31Z

On 2020-06-16 15:13, Thomas Huth wrote:
> On 15/06/2020 11.31, Pierre Morel wrote:
>> This patch defines the PSW bits EA/BA used to initialize the PSW masks
>> for exceptions.

...snip...

>> svc_int_psw:
>> - .quad 0x0000000180000000, svc_int
>> + .quad PSW_MASK_ON_EXCEPTION, svc_int
>> initial_cr0:
>> /* enable AFP-register control, so FP regs (+BFP instr) can be used */
>> .quad 0x0000000000040000
>>
>
> I'm afraid, by when I compile this on RHEL7, the toolchain complains:
>
> s390x/cstart64.S: Assembler messages:
> s390x/cstart64.S:239: Error: found 'L', expected: ')'
> s390x/cstart64.S:239: Error: junk at end of line, first unrecognized
...snip...
> character is `L'
> s390x/cstart64.S:254: Error: junk at end of line, first unrecognized
> character is `L'
>
> Shall we skip the update to the assembler file for now?

I think it is the best to do to go rapidly forward.

alternative:
I propose a local macro for the PSW_MASK_ON_EXCEPTION and
PSW_MASK_SHORT_PSW inside the assembler in the respin, put it at the end
of the serie and we choose if we keep the changes of csstart.S

this would not slow us.

Should I keep your RB for the arch_def.h ?

thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen