Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stefan Teodorescu <fane@google.com>,
	Dennis Tighe <dtighe@google.com>,
	Sashiko Bot <sashiko-bot@kernel.org>,
	Yan Zhao <yan.y.zhao@intel.com>
Subject: Re: [PATCH v3 2/4] KVM: Use goto to handle errors during memslot preparation
Date: Mon, 7 Sep 2026 19:36:04 +0200	[thread overview]
Message-ID: <fd1d92d4-449a-47c3-b585-9d6105c3afb6@kernel.org> (raw)
In-Reply-To: <20260904004342.3162959-3-seanjc@google.com>

On 9/4/26 02:43, Sean Christopherson wrote:
> Use a goto to unwind early memslot changes if preparing for a memslot
> operation fails.  This will allow moving the creation of guest_memfd
> bindings into kvm_set_memslot() without needing to copy+paste the unwind
> logic.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

  reply	other threads:[~2026-09-07 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  0:43 [PATCH v3 0/4] KVM: guest_memfd: Fix binding bugs Sean Christopherson
2026-09-04  0:43 ` [PATCH v3 1/4] KVM: guest_memfd: Gracefully handle xarray errors when binding a memslot Sean Christopherson
2026-09-07 17:34   ` David Hildenbrand (Arm)
2026-09-09 19:27     ` Sean Christopherson
2026-09-09 22:59     ` Ackerley Tng
2026-09-10  0:11       ` Sean Christopherson
2026-09-04  0:43 ` [PATCH v3 2/4] KVM: Use goto to handle errors during memslot preparation Sean Christopherson
2026-09-07 17:36   ` David Hildenbrand (Arm) [this message]
2026-09-09 23:09   ` Ackerley Tng
2026-09-04  0:43 ` [PATCH v3 3/4] KVM: guest_memfd: Establish memslot<=>guest_memfd bindings *after* memslot is ready Sean Christopherson
2026-09-07 17:47   ` David Hildenbrand (Arm)
2026-09-09 21:53     ` Sean Christopherson
2026-09-04  0:43 ` [PATCH v3 4/4] KVM: guest_memfd: Drop superfluous WRITE_ONCE() when binding a memslot Sean Christopherson
2026-09-07 17:47   ` David Hildenbrand (Arm)
2026-09-09 23:06   ` Ackerley Tng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd1d92d4-449a-47c3-b585-9d6105c3afb6@kernel.org \
    --to=david@kernel.org \
    --cc=dtighe@google.com \
    --cc=fane@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sashiko-bot@kernel.org \
    --cc=seanjc@google.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox