Re: [PATCH v3 9/9] iommu: Make set_dev_pasid op support domain replacement

[Yi Liu <yi.l.liu@intel.com>]

On 2024/10/21 14:27, Baolu Lu wrote:
> On 2024/10/18 13:54, Yi Liu wrote:
>> The iommu core is going to support domain replacement for pasid, it needs
>> to make the set_dev_pasid op support replacing domain and keep the old
>> domain config in the failure case.
>>
>> AMD iommu driver does not support domain replacement for pasid yet, so it
>> would fail the set_dev_pasid op to keep the old config if the input @old
>> is non-NULL.
>>
>> Suggested-by: Jason Gunthorpe<jgg@nvidia.com>
>> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
>> Reviewed-by: Kevin Tian<kevin.tian@intel.com>
>> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
>> ---
>>   drivers/iommu/amd/pasid.c | 3 +++
>>   include/linux/iommu.h     | 3 ++-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
> 
> I would suggest merging this patch with patch 1/9.

If merging it with patch 01, none of the drivers is ready for the new
definition. With the current order, the new definition are claimed after
all the drivers are ready. So it seems more reasonable. Also good from
bisect p.o.v. is it?:)

-- 
Regards,
Yi Liu