public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hoo <robert.hu@linux.intel.com>
To: seanjc@google.com, pbonzini@redhat.com, jmattson@google.com
Cc: kvm@vger.kernel.org, yu.c.zhang@linux.intel.com, robert.hu@intel.com
Subject: Re: [kvm-unit-tests PATCH] x86/vmx: Deprecate VMX_VMCS_ENUM.MAX_INDEX check in vmread/vmwrite test
Date: Mon, 06 Dec 2021 17:48:32 +0800	[thread overview]
Message-ID: <fe75d1fea273ef4f50f9e656f650a215276675f0.camel@linux.intel.com> (raw)
In-Reply-To: <1637306107-92967-1-git-send-email-robert.hu@linux.intel.com>

Ping...
Thanks.
On Fri, 2021-11-19 at 15:15 +0800, Robert Hoo wrote:
> From: Yu Zhang <yu.c.zhang@linux.intel.com>
> 
> The actual value of vmcs12.vmcs_enum is set by QEMU, with hard code,
> while the expected value in this test is got from literally
> traversing
> vmcs12 fields. They probably mismatch, depends on KVM version and
> QEMU
> version used. It doesn't mean QEMU or KVM is buggy.
> 
> We deprecate this failure report, as we "don't see any point in
> fighting
> too hard with QEMU."[1]
> We keep its log here as hint.
> 
> [1] https://lore.kernel.org/kvm/YZWqJwUrF2Id9hM2@google.com/
> 
> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> ---
>  x86/vmx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/x86/vmx.c b/x86/vmx.c
> index 7a2f7a3..7e191dd 100644
> --- a/x86/vmx.c
> +++ b/x86/vmx.c
> @@ -379,8 +379,7 @@ static void test_vmwrite_vmread(void)
>  	vmcs_enum_max = (rdmsr(MSR_IA32_VMX_VMCS_ENUM) &
> VMCS_FIELD_INDEX_MASK)
>  			>> VMCS_FIELD_INDEX_SHIFT;
>  	max_index = find_vmcs_max_index();
> -	report(vmcs_enum_max == max_index,
> -	       "VMX_VMCS_ENUM.MAX_INDEX expected: %x, actual: %x",
> +	printf("VMX_VMCS_ENUM.MAX_INDEX expected: %x, actual: %x\n",
>  	       max_index, vmcs_enum_max);
>  
>  	assert(!vmcs_clear(vmcs));


      reply	other threads:[~2021-12-06  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  7:15 [kvm-unit-tests PATCH] x86/vmx: Deprecate VMX_VMCS_ENUM.MAX_INDEX check in vmread/vmwrite test Robert Hoo
2021-12-06  9:48 ` Robert Hoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe75d1fea273ef4f50f9e656f650a215276675f0.camel@linux.intel.com \
    --to=robert.hu@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=robert.hu@intel.com \
    --cc=seanjc@google.com \
    --cc=yu.c.zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox