Re: [PATCH v2 0/4] vfio-mdev: Fix remove race, clean namespace and better define ABI

Kirti Wankhede
2016-12-26T03:31:35Z

On 12/23/2016 1:51 AM, Alex Williamson wrote:
> Cleanup the namespace a bit by prefixing structures with mdev_ and
> also more concretely define the mdev interface. Structs with comments
> defining which fields are private vs public tempts poor behavior,
> especially for an interface where we expect out of tree vendor drivers.
>

Patch 2/4-4/4 looks good to me.

Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>

Thanks,
Kirti

> Additionally in v2, the patch removing the next field from mdev_device
> is dropped, instead using it to fix a remove race, my From address is
> fixed, and Documentation is updated. Jike, I left your R-b on the
> patches that didn't change only. If I've missed any relevant doc
> updates, please let me know. Thanks,
>
> Alex
>
> ---
>
> Alex Williamson (4):
> vfio-mdev: Fix remove race
> vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
> vfio-mdev: Make mdev_parent private
> vfio-mdev: Make mdev_device private and abstract interfaces
>
>
> Documentation/vfio-mediated-device.txt | 27 +++++----
> drivers/gpu/drm/i915/gvt/kvmgt.c | 22 ++++---
> drivers/vfio/mdev/mdev_core.c | 100 +++++++++++++++++++++++++++-----
> drivers/vfio/mdev/mdev_private.h | 29 ++++++++-
> drivers/vfio/mdev/mdev_sysfs.c | 8 +--
> drivers/vfio/mdev/vfio_mdev.c | 12 ++--
> include/linux/mdev.h | 54 ++++-------------
> samples/vfio-mdev/mtty.c | 28 +++++----
> 8 files changed, 173 insertions(+), 107 deletions(-)
>