Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

[Hollis Blanchard]

On Sun, 02 Dec 2007 10:50:06 +0200, Avi Kivity wrote:
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 368864d..eded44e
> 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -112,6 +112,9 @@ config GENERIC_TIME_VSYSCALL
>  	bool
>  	default X86_64
>  
> +config ARCH_SUPPORTS_KVM
> +	bool
> +	default y
>  
>  
>  
> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index
> 6569206..4086080 100644
> --- a/drivers/kvm/Kconfig
> +++ b/drivers/kvm/Kconfig
> @@ -3,7 +3,7 @@
>  #
>  menuconfig VIRTUALIZATION
>  	bool "Virtualization"
> -	depends on X86
> +	depends on ARCH_SUPPORTS_KVM || X86
>  	default y
>  	---help---
>  	  Say Y here to get to see options for using your Linux host to 
run
>  	  other

I think this approach is fine, but don't forget that lguest was snuck 
into drivers/kvm/Kconfig. It might be a good idea to move 
CONFIG_VIRTUALIZATION into drivers/Kconfig at this point... maybe a task 
for Rusty.

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

[Avi Kivity]

Hollis Blanchard wrote:
>>  
>> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index
>> 6569206..4086080 100644
>> --- a/drivers/kvm/Kconfig
>> +++ b/drivers/kvm/Kconfig
>> @@ -3,7 +3,7 @@
>>  #
>>  menuconfig VIRTUALIZATION
>>  	bool "Virtualization"
>> -	depends on X86
>> +	depends on ARCH_SUPPORTS_KVM || X86
>>  	default y
> I think this approach is fine, but don't forget that lguest was snuck 
> into drivers/kvm/Kconfig. 

Actually I considered this. X86 in the depends statement above is short 
for "ARCH_SUPPORTS_LGUEST"; otherwise it is not needed.


> It might be a good idea to move 
> CONFIG_VIRTUALIZATION into drivers/Kconfig at this point

I prefer a top-level virt/ and arch/*/virt/.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4