[PATCH] autoport overrides actual VNC port number in dump-xml

[PATCH] autoport overrides actual VNC port number in dump-xml

[Charles Duffy]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Per subject; if autoport is in use for a host, the current 
virDomainGraphicsDefFormat code always emits "port=-1", even if a port 
is assigned to the host; this leaves no way for a client to find the VNC 
  port assigned to the host in question.

[-- Attachment #2: libvirt-fix-vnc-port-output.patch --]
[-- Type: text/x-diff, Size: 737 bytes --]

diff --git a/src/domain_conf.c b/src/domain_conf.c
index d629093..ece471e 100644
--- a/src/domain_conf.c
+++ b/src/domain_conf.c
@@ -2431,11 +2431,11 @@ virDomainGraphicsDefFormat(virConnectPtr conn,
 
     switch (def->type) {
     case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
-        if (def->data.vnc.autoport)
-            virBufferAddLit(buf, " port='-1'");
-        else if (def->data.vnc.port)
+        if (def->data.vnc.port)
             virBufferVSprintf(buf, " port='%d'",
                               def->data.vnc.port);
+        else if (def->data.vnc.autoport)
+            virBufferAddLit(buf, " port='-1'");
 
         virBufferVSprintf(buf, " autoport='%s'",
                           def->data.vnc.autoport ? "yes" : "no");

Re: [PATCH] autoport overrides actual VNC port number in dump-xml

[Daniel P. Berrange]

On Wed, Jul 30, 2008 at 12:32:57AM -0500, Charles Duffy wrote:
> Per subject; if autoport is in use for a host, the current 
> virDomainGraphicsDefFormat code always emits "port=-1", even if a port 
> is assigned to the host; this leaves no way for a client to find the VNC 
>  port assigned to the host in question.

You've got the wrong mailing list here - you want the libvirt list
at  libvir-list@redhat.com

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|