From: Charles Duffy <Charles_Duffy@messageone.com>
To: kvm@vger.kernel.org
Subject: Re: [PATCH] Kvm: Qemu: save nvram
Date: Wed, 17 Dec 2008 12:39:02 -0600 [thread overview]
Message-ID: <gibh06$cm7$1@ger.gmane.org> (raw)
In-Reply-To: <10C63FAD690C13458F0B32BCED571F1403A96C9C@pdsmsx502.ccr.corp.intel.com>
Zhang, Yang wrote:
> Hi
> Please drop former.
> This is the modify patch for save nvram.
> I add the new command line arg of "-nvram file" to specify the location
> Of the file. Without the arg ,it will save the nvram in the current dir
> and named as "nvram.dat". Also, it will read the saved file "nvram.dat"
> from current dir without the arg.
Speaking with my end-user hat on, this seems to violate the principal of
least surprise:
I would expect NVRAM contents to be discarded, not saved to a file in
the current working directory, if no relevant option were given on the
command line.
Likewise, I would expect NVRAM contents to be initialized exactly as
they are right now (even if that means no initialization at all) if no
path were given.
next prev parent reply other threads:[~2008-12-17 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 2:25 [PATCH] Kvm: Qemu: save nvram Zhang, Yang
2008-12-02 5:27 ` Zhang, Yang
2008-12-02 10:31 ` Daniel P. Berrange
2008-12-02 13:01 ` Avi Kivity
2008-12-02 13:10 ` Daniel P. Berrange
2008-12-03 6:02 ` Zhang, Xiantao
2008-12-03 6:12 ` Zhang, Yang
2008-12-16 9:21 ` Zhang, Yang
2008-12-17 18:39 ` Charles Duffy [this message]
2008-12-18 5:30 ` Zhang, Xiantao
2008-12-18 18:00 ` Charles Duffy
2008-12-19 1:56 ` Zhang, Yang
2008-12-24 5:27 ` Zhang, Yang
2008-12-24 5:34 ` Zhang, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gibh06$cm7$1@ger.gmane.org' \
--to=charles_duffy@messageone.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox