From mboxrd@z Thu Jan  1 00:00:00 1970
From: Charles Duffy <Charles_Duffy@messageone.com>
Subject: Re: [PATCH] Kvm: Qemu: save nvram
Date: Wed, 17 Dec 2008 12:39:02 -0600
Message-ID: <gibh06$cm7$1@ger.gmane.org>
References: <10C63FAD690C13458F0B32BCED571F14021760D4@pdsmsx502.ccr.corp.intel.com> <20081202103145.GC25599@redhat.com> <493531A0.2040501@redhat.com> <20081202131015.GQ25599@redhat.com> <706158FABBBA044BAD4FE898A02E4BC219C1AD8C@pdsmsx503.ccr.corp.intel.com> <10C63FAD690C13458F0B32BCED571F14021769BA@pdsmsx502.ccr.corp.intel.com> <10C63FAD690C13458F0B32BCED571F1403A96C9C@pdsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from main.gmane.org ([80.91.229.2]:52870 "EHLO ciao.gmane.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751041AbYLQSjS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Dec 2008 13:39:18 -0500
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1LD1If-0001Md-0H
	for kvm@vger.kernel.org; Wed, 17 Dec 2008 18:39:13 +0000
Received: from rrcs-71-41-149-67.sw.biz.rr.com ([71.41.149.67])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <kvm@vger.kernel.org>; Wed, 17 Dec 2008 18:39:12 +0000
Received: from Charles_Duffy by rrcs-71-41-149-67.sw.biz.rr.com with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <kvm@vger.kernel.org>; Wed, 17 Dec 2008 18:39:12 +0000
In-Reply-To: <10C63FAD690C13458F0B32BCED571F1403A96C9C@pdsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Zhang, Yang wrote:
> Hi
> Please drop former. 
> This is the modify patch for save nvram.
> I add the new command line arg of "-nvram file" to specify the location 
> Of the file. Without the arg ,it will save the nvram in the current dir 
> and named as "nvram.dat". Also, it will read the saved file "nvram.dat" 
> from current dir without the arg.

Speaking with my end-user hat on, this seems to violate the principal of 
least surprise:

I would expect NVRAM contents to be discarded, not saved to a file in 
the current working directory, if no relevant option were given on the 
command line.

Likewise, I would expect NVRAM contents to be initialized exactly as 
they are right now (even if that means no initialization at all) if no 
path were given.