From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Duffy Subject: Re: [PATCH] Kvm: Qemu: save nvram Date: Thu, 18 Dec 2008 12:00:20 -0600 Message-ID: References: <10C63FAD690C13458F0B32BCED571F14021760D4@pdsmsx502.ccr.corp.intel.com> <20081202103145.GC25599@redhat.com> <493531A0.2040501@redhat.com> <20081202131015.GQ25599@redhat.com> <706158FABBBA044BAD4FE898A02E4BC219C1AD8C@pdsmsx503.ccr.corp.intel.com> <10C63FAD690C13458F0B32BCED571F14021769BA@pdsmsx502.ccr.corp.intel.com> <10C63FAD690C13458F0B32BCED571F1403A96C9C@pdsmsx502.ccr.corp.intel.com> <706158FABBBA044BAD4FE898A02E4BC21C7FCDE8@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from main.gmane.org ([80.91.229.2]:58372 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753241AbYLRSAn (ORCPT ); Thu, 18 Dec 2008 13:00:43 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LDNAq-0005dk-Qj for kvm@vger.kernel.org; Thu, 18 Dec 2008 18:00:37 +0000 Received: from rrcs-71-41-149-67.sw.biz.rr.com ([71.41.149.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 18 Dec 2008 18:00:36 +0000 Received: from Charles_Duffy by rrcs-71-41-149-67.sw.biz.rr.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 18 Dec 2008 18:00:36 +0000 In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21C7FCDE8@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > Charles Duffy wrote: >> Speaking with my end-user hat on, this seems to violate the principal >> of least surprise: >> >> I would expect NVRAM contents to be discarded, not saved to a file in >> the current working directory, if no relevant option were given on the >> command line. > > Maybe better to generate a temporary file to save the data instead of discarding it? An unlinked temporary file as default behavior makes good sense -- it doesn't leave anything sitting around the user didn't ask for or doesn't expect, so it wouldn't be surprising behavior to me as an end-user, but provides a method for persisting nvram contents during a single session.