From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Duffy Subject: Re: kvm-autotest new test, save and load Date: Mon, 06 Apr 2009 18:54:35 -0500 Message-ID: References: <1239046863-11939-1-git-send-email-dhuff@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from main.gmane.org ([80.91.229.2]:52073 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbZDFXyp (ORCPT ); Mon, 6 Apr 2009 19:54:45 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LqyeI-0001Dt-Kj for kvm@vger.kernel.org; Mon, 06 Apr 2009 23:54:42 +0000 Received: from 143.166.197.6 ([143.166.197.6]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Apr 2009 23:54:42 +0000 Received: from charles by 143.166.197.6 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Apr 2009 23:54:42 +0000 In-Reply-To: <1239046863-11939-1-git-send-email-dhuff@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: David Huff wrote: > Submitting new test for review and comments. > This test was originally developed by the Red Hat QE team. > It starts a new guest saves it and reloads the saved state. > > looking for comments and or improvements that can be made to this test. I have some code (aimed at testing software within the guest, rather than kvm itself) which does this kind of operation quite frequently; the most common case where I've seen failures happen is when writes are active while state is being saved. One enhancement might be to test the integrity of block device writes being done during the save/restore process itself -- for instance, write a file of all high bits, start a process overwriting it with all low bits, run the save and restore before the latter process has completed, and ensure that after the migration is complete and the process has finished, the file contains nothing but 0s.