From: Bandan Das <bsd@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: make halt_poll_ns static
Date: Tue, 03 Mar 2015 16:42:45 -0500 [thread overview]
Message-ID: <jpg61ahrc4q.fsf@redhat.com> (raw)
In-Reply-To: 1425052210-27497-1-git-send-email-borntraeger@de.ibm.com
Christian Borntraeger <borntraeger@de.ibm.com> writes:
> halt_poll_ns is used only locally. Make it static.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns = 0;
We should remove the initialization to zero. (Unfortunately,
the usage pattern throughout the kernel code is not constant..)
Bandan
> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>
> /*
next prev parent reply other threads:[~2015-03-03 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 15:50 [PATCH] KVM: make halt_poll_ns static Christian Borntraeger
2015-03-03 21:42 ` Bandan Das [this message]
2015-03-03 21:46 ` Christian Borntraeger
2015-03-09 12:15 ` Christian Borntraeger
2015-03-09 21:38 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpg61ahrc4q.fsf@redhat.com \
--to=bsd@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox