From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bandan Das <bsd@redhat.com>
Subject: Re: [PATCH] KVM: make halt_poll_ns static
Date: Tue, 03 Mar 2015 16:42:45 -0500
Message-ID: <jpg61ahrc4q.fsf@redhat.com>
References: <1425052210-27497-1-git-send-email-borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KVM <kvm@vger.kernel.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46054 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757779AbbCCVmu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 3 Mar 2015 16:42:50 -0500
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Christian Borntraeger <borntraeger@de.ibm.com> writes:

> halt_poll_ns is used only locally. Make it static.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
>  MODULE_AUTHOR("Qumranet");
>  MODULE_LICENSE("GPL");
>  
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns = 0;

We should remove the initialization to zero. (Unfortunately,
the usage pattern throughout the kernel code is not constant..)

Bandan
>  module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>  
>  /*