From: Bandan Das <bsd@redhat.com>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: Wincy Van <fanwenyi0529@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] KVM: x86: nVMX: support for MSR loading/storing
Date: Wed, 10 Dec 2014 15:14:47 +0530 [thread overview]
Message-ID: <jpg8uifg7ow.fsf@redhat.com> (raw)
In-Reply-To: <CAJC2YLaymcxmjCRTdzD-TChhe0gt8qd=Bqe5pz825S+Ha5HOaQ@mail.gmail.com> (Eugene Korenevsky's message of "Wed, 10 Dec 2014 08:07:45 -0100")
Eugene Korenevsky <ekorenevsky@gmail.com> writes:
>> Hi, Eugene, is it okay to split my part up?
>
> I think the patch is atomic. No ideas how this patch could be split
> without breaking its integrity.
> You are a co-author of the patch since your ideas make significant part of it.
I was suggesting adding the interfaces you introduced in the first patch
and then using these interfaces in the second patch to make reviewing easier.
It's ok to mention that the second depends on the first.
If Wincy has code contributions to the patch, he should sign it off too,
else maybe add a Suggested-by to give him credit for his ideas.
Also, please include a "v3" in the Subject when you submit your next version.
next prev parent reply other threads:[~2014-12-10 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 0:41 [PATCH] KVM: x86: nVMX: support for MSR loading/storing Eugene Korenevsky
2014-12-09 14:05 ` Bandan Das
2014-12-09 21:12 ` Eugene Korenevsky
2014-12-10 2:00 ` Wincy Van
2014-12-10 9:07 ` Eugene Korenevsky
2014-12-10 9:01 ` Wanpeng Li
2014-12-10 9:35 ` Wincy Van
2014-12-10 9:44 ` Bandan Das [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-09 21:18 Eugene Korenevsky
2014-12-09 21:59 ` Radim Krčmář
2014-12-10 9:08 ` Eugene Korenevsky
2014-12-10 9:13 ` Eugene Korenevsky
2014-12-10 9:02 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpg8uifg7ow.fsf@redhat.com \
--to=bsd@redhat.com \
--cc=ekorenevsky@gmail.com \
--cc=fanwenyi0529@gmail.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox