From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bandan Das <bsd@redhat.com>
Subject: Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found
Date: Thu, 09 Apr 2015 13:20:26 -0400
Message-ID: <jpga8yhnrqd.fsf@redhat.com>
References: <jpg384j1rkm.fsf@redhat.com> <551D3A47.1030404@redhat.com>
	<5526AC5E.7050803@redhat.com> <jpgwq1lrzqb.fsf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47437 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753722AbbDIRU2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Apr 2015 13:20:28 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 54C2CA10B3
	for <kvm@vger.kernel.org>; Thu,  9 Apr 2015 17:20:28 +0000 (UTC)
In-Reply-To: <jpgwq1lrzqb.fsf@redhat.com> (Bandan Das's message of "Thu, 09
	Apr 2015 13:14:04 -0400")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Bandan Das <bsd@redhat.com> writes:
...
>
> I think we still want to print this if the user supplied qemu has no test
> device support. I think this is better -
> --- a/x86/run
> +++ b/x86/run
> @@ -8,6 +8,7 @@ qemusystem="${QEMU:-qemu-system-x86_64}"
>  if      ! [ -z "${QEMU}" ]
>  then
>         qemu="${QEMU}"
> +       QEMUFOUND=1
>  else

Damn, please ignore the previous message. This does nothing and I
need more sleep.

Bandan

>         for qemucmds in ${qemukvm} ${qemusystem}
>         do
>
>> +		exit ${TESTDEVNOTSUPP}
>> +	fi
>>  fi
>>  
>>  if
>>
>> which apart from reindentation is just moving a "fi" down.
>> Paolo