From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bandan Das <bsd@redhat.com>
Subject: Re: RFC: silencing kvm unimplemented msr spew.
Date: Fri, 22 Jul 2016 12:37:58 -0400
Message-ID: <jpgbn1py6ft.fsf@linux.bootlegged.copy>
References: <20160715192729.GA4712@fb.com>
	<110045299.8101686.1468855610053.JavaMail.zimbra@redhat.com>
	<20160719195856.GA31453@fb.com>
	<jpgzipdjs00.fsf@linux.bootlegged.copy>
	<20160721202440.GA10908@fb.com>
	<844431780.9635789.1469177321917.JavaMail.zimbra@redhat.com>
	<jpgshv1d5gn.fsf@linux.bootlegged.copy>
	<1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Dave Jones <dsj@fb.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com>
	(Paolo Bonzini's message of "Fri, 22 Jul 2016 12:20:27 -0400 (EDT)")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Paolo Bonzini <pbonzini@redhat.com> writes:

>> >> Paolo, would you prefer this, or the other approach you already ack'd ?
>> >
>> > I think I prefer the other, because vcpu_debug is not ratelimited.
>> > If the guest can trigger a printk it should always be ratelimited.
>> 
>> Agree with rate limiting, but making this the default for everything doesn't
>> sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate
>> limited.
>
> The problem is that your patch removes rate limiting whenever it now
> uses vcpu_debug.

I was suggesting Dave to do something like what I posted but with a new
vcpu_debug_ratelimited.

> Paolo