public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: KVM <kvm@vger.kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH kvm-unit-tests] cscope: fix database generation
Date: Mon, 18 Apr 2016 19:04:55 -0400	[thread overview]
Message-ID: <jpgh9eybjs8.fsf@linux.bootlegged.copy> (raw)


The cscope.files that we generate doesn't include all
source files that are potentially interesting. We should
include all $(ARCH)es  and not the just the one configure
finds. Moreover, $(ARCH) expands to x86_64 which is not the
correct path for x86 sources. Generate cscope.files by searching
for all files starting from root.

While we are there, remove the unnecessary sed substitution
and modify find to include a few other file name extensions.

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 Makefile  | 9 +++------
 configure | 2 ++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 5d7506e..458d0f0 100644
--- a/Makefile
+++ b/Makefile
@@ -92,11 +92,8 @@ distclean: clean libfdt_clean
 	$(RM) lib/asm config.mak $(TEST_DIR)-run test.log msr.out cscope.*
 	$(RM) -r tests
 
-cscope: cscope_dirs = lib lib/libfdt lib/linux
-cscope: cscope_dirs += lib/$(ARCH)/asm lib/$(TEST_DIR)/asm lib/asm-generic
-cscope: cscope_dirs += $(TEST_DIR) lib/$(TEST_DIR) lib/$(ARCH)
 cscope:
-	$(RM) ./cscope.*
-	find -L $(cscope_dirs) -maxdepth 1 \
-		-name '*.[chsS]' -print | sed 's,^\./,,' | sort -u > ./cscope.files
+	$(RM) $(SRCDIR)/cscope.*
+	find -L $(SRCDIR) -maxdepth 3 \
+		-regex '.*\.\(c\|h\|cc\|S\|sh\|bash\|s\)$$' -print | sort -u > ./cscope.files
 	cscope -bk
diff --git a/configure b/configure
index ba6c55b..3153fb9 100755
--- a/configure
+++ b/configure
@@ -12,6 +12,7 @@ host=$arch
 cross_prefix=
 endian=""
 pretty_print_stacks=yes
+srcdir=`pwd`
 
 usage() {
     cat <<-EOF
@@ -159,4 +160,5 @@ TEST_DIR=$testdir
 FIRMWARE=$firmware
 ENDIAN=$endian
 PRETTY_PRINT_STACKS=$pretty_print_stacks
+SRCDIR=$srcdir
 EOF
-- 
2.5.5


             reply	other threads:[~2016-04-18 23:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 23:04 Bandan Das [this message]
2016-04-19  5:25 ` [PATCH kvm-unit-tests] cscope: fix database generation Andrew Jones
2016-04-19 17:08   ` Bandan Das
2016-04-19 18:38     ` Radim Krčmář
2016-04-19 18:58       ` Bandan Das
2016-04-19 19:22         ` Radim Krčmář
2016-04-19 19:44           ` Bandan Das
2016-04-20  8:43             ` Andrew Jones
2016-04-20 14:31               ` Bandan Das
2016-04-20 14:45                 ` Andrew Jones
2016-05-10 13:55 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jpgh9eybjs8.fsf@linux.bootlegged.copy \
    --to=bsd@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox