From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [PATCH kvm-unit-tests] cscope: fix database generation Date: Tue, 19 Apr 2016 14:58:20 -0400 Message-ID: References: <20160419052510.t2xkdunwjmwvry77@hawk.localdomain> <20160419183845.GB10102@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Jones , KVM , Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49621 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbcDSS6W convert rfc822-to-8bit (ORCPT ); Tue, 19 Apr 2016 14:58:22 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6DBBC85365 for ; Tue, 19 Apr 2016 18:58:22 +0000 (UTC) In-Reply-To: <20160419183845.GB10102@potion.brq.redhat.com> ("Radim \=\?utf-8\?B\?S3LEjW3DocWZIidz\?\= message of "Tue, 19 Apr 2016 20:38:45 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Radim Kr=C4=8Dm=C3=A1=C5=99 writes: > 2016-04-19 13:08-0400, Bandan Das: >> Andrew Jones writes: >>> On Mon, Apr 18, 2016 at 07:04:55PM -0400, Bandan Das wrote: >>>>=20 >>>> The cscope.files that we generate doesn't include all >>>> source files that are potentially interesting. We should >>>> include all $(ARCH)es and not the just the one configure >>>> finds. Moreover, $(ARCH) expands to x86_64 which is not the >>>> correct path for x86 sources. Generate cscope.files by searching >>>> for all files starting from root. >>> >>> No thanks :-) I'd rather not get hits for x86 and powerpc when >>=20 >> I don't think that's a good idea. Just because you don't like to >> see x86 bits when jumping around in arm code doesn't mean you should >> hide all references to a given function. And if the arm code is >> segregated enough that there are no common functions, you won't >> see them anyway.=20 >> [...] But please let's >> not make it difficult to write arm/powerpc tests just because someon= e's on >> x86 :) > > In the kernel, environment can override configuration, so you'd do > > % ARCH=3Darm make cscope > > and it doesn't matter what arch is being compiled. I think this woul= d > be a better solution for kvm-unit-tests too. > > I agree with Drew that other arches would mostly clutter searches if > they were included by default, but we can also add a rule in case Since you mentioned the kernel, it looks like both the kernel/qemu include all by default which makes sense to me. As I mentioned above, you definitely don't want to modify a common library function only to realize that you forgot to modify all sites. Looking at all sites adds visibility, not introduce clutter. > indexing all arches is desired (like when changing the prototype of s= ome > generic function?). kvm-unit-tests is small enough that this can be the default. That said,= this is a trivial change and I am happy to live with it in my local branch. = (Unless ofcourse both Linux and Qemu decide to make this default behavior too!)