From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jim Mattson <jmattson@google.com>,
kvm@vger.kernel.org, dmatlack@google.com, pfeiner@google.com
Subject: Re: [PATCH] kvm: nVMX: Track active shadow VMCSs
Date: Sat, 16 Jul 2016 15:48:39 -0400 [thread overview]
Message-ID: <jpgmvlhgy94.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <78dd4e63-ca2e-4317-0d51-d1fa08958edc@redhat.com> (Paolo Bonzini's message of "Sat, 16 Jul 2016 16:50:22 +0200")
Hi Paolo,
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 16/07/2016 02:50, Bandan Das wrote:
>>> > + int ret = setup_shadow_vmcs(vmx);
>>> > + if (ret)
>>> > + return ret;
>> Nit:
>> if (setup_shadow_vmcs(vmx))
>> return -ENOMEM;
>
> Nope, -errno is a much better return value than bool, because you never
> know if bool means success or failure. Jim's patch got it right. :)
This doesn't seem to be ambiguous in the context of setup_shadow_vmcs since
it has one error path and it always returns 0 on success. Just a nit to get rid of
that local variable...
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-16 19:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:39 [PATCH] kvm: nVMX: Track active shadow VMCSs Jim Mattson
2016-07-16 0:50 ` Bandan Das
2016-07-16 14:50 ` Paolo Bonzini
2016-07-16 19:48 ` Bandan Das [this message]
2016-07-19 16:22 ` Jim Mattson
2016-07-22 18:25 ` [PATCH v2] KVM: " Jim Mattson
2016-07-27 20:45 ` Radim Krčmář
2016-07-27 21:53 ` Bandan Das
2016-07-28 13:30 ` Jim Mattson
2016-07-28 14:01 ` Radim Krčmář
2016-10-28 15:29 ` [PATCH v2] kvm: nVMX: VMCLEAR an active shadow VMCS after last use Jim Mattson
2016-11-02 17:23 ` Paolo Bonzini
2016-11-02 17:56 ` Jim Mattson
2016-11-02 18:04 ` Paolo Bonzini
2016-07-18 21:30 ` [PATCH] kvm: nVMX: Track active shadow VMCSs Jim Mattson
2016-07-18 23:36 ` Bandan Das
2016-07-19 8:41 ` Paolo Bonzini
2016-07-19 16:13 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgmvlhgy94.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox